fix: Use absolute (relative to repo root) path to supplied filename#1152
Open
mattcen wants to merge 4 commits into
Open
fix: Use absolute (relative to repo root) path to supplied filename#1152mattcen wants to merge 4 commits into
mattcen wants to merge 4 commits into
Conversation
If a file is referenced from the subdir of a repository, the script confirms it exists and tacks the filename onto the URL, but doesn't check if the filename provided is relative to the repo root.
|
This PR was closed because it has been stalled for 365 days with no activity. Feel free to make a new PR if you wish to continue |
Collaborator
|
@mattcen |
Author
|
@spacewander happy for review, with the caveat I never worked out how to update tests as per PR description |
spacewander
reviewed
May 13, 2026
Collaborator
|
Looks like we need to update the tests. |
Collaborator
|
Would you update other test files too? |
Author
|
I could not immediately work out how they worked or how to update them in the time I had available, which is why this wasn't completed when I first opened the PR. I will try to take another look at them, but am not sure how soon that will be; any guidance or suggestions you can provide would be much appreciated. |
Collaborator
|
Maybe you can change Line 47 in 99207ee |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a file is referenced from the subdir of a repository, the script confirms it exists and tacks the filename onto the URL, but doesn't check if the filename provided is relative to the repo root.
I couldn't immediately work out the best way to update the tests to: