Fix IndexError when data has a single blink occurring at the start of the sequence #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the sequence Previously, if the data contained only one blink, and the blink occured at the start of the sequence (ie. pupil size is -1 for first index), blink onset would be empty, but length_blinks would be greater than zero because blink offset would not be empty. This would cause an IndexError when attempting to access blink_onset[0]. This change adds a guard clause to handle this edge case and prevent the error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if the data contained only one blink, and the blink occured at the start of the sequence (ie. pupil size is -1 for first index), blink onset would be empty, but length_blinks would be greater than zero because blink offset would not be empty. This would cause an IndexError when attempting to access blink_onset[0]. This change adds a guard clause to handle this edge case and prevent the error.