Override findOneByColumn, findAllByColumn and sum to use deletiontimestamp.#31
Conversation
… deletion timestamp.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| */ | ||
| public function findAllByColumn($column) | ||
| { | ||
| if ($this->definition->getDeletionTimestamp()) { |
Check notice
Code scanning / Psalm
RiskyTruthyFalsyComparison Note
| */ | ||
| public function findOneColumn($column) | ||
| { | ||
| if ($this->definition->getDeletionTimestamp()) { |
Check notice
Code scanning / Psalm
RiskyTruthyFalsyComparison Note
| */ | ||
| public function sum(string $column) | ||
| { | ||
| if ($this->definition->getDeletionTimestamp()) { |
Check notice
Code scanning / Psalm
RiskyTruthyFalsyComparison Note
|
Looks good. Could you please address the Psalm issues before we merge. There's some annotations needed because you're overriding methods on |
|
@joshmcrae not sure how psalm manages to pick just these things out, if I run it locally it produces tons of errors 😅 I've made the changes for those specific ones it's upset about 👍 |
3 participants
This should be the last of the methods we need to override to use the deletion timestamp.