Fix deprecation notice on PHP 8.5 about using null for array access.#29
Merged
joshmcrae merged 2 commits intotithely:masterfrom Apr 1, 2026
Merged
Fix deprecation notice on PHP 8.5 about using null for array access.#29joshmcrae merged 2 commits intotithely:masterfrom
joshmcrae merged 2 commits intotithely:masterfrom
Conversation
This resolves it, plus slightly improves performance.
rrigby
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| $mapping | ||
| ->join($property->getJoinTable(), $property->getJoinLocalColumn(), $property->getForeignColumn()) | ||
| ->in(sprintf('%s.%s', $property->getJoinTable(), $property->getJoinForeignColumn()), array_column($data, $property->getLocalColumn())); | ||
| ->in(sprintf('%s.%s', $property->getJoinTable(), $property->getJoinForeignColumn()), $localValues); |
Check failure
Code scanning / Psalm
PossiblyNullArgument Error
| $mapping | ||
| ->join($property->getJoinTable(), $property->getJoinLocalColumn(), $property->getForeignColumn()) | ||
| ->in(sprintf('%s.%s', $property->getJoinTable(), $property->getJoinForeignColumn()), array_column($data, $property->getLocalColumn())); | ||
| ->in(sprintf('%s.%s', $property->getJoinTable(), $property->getJoinForeignColumn()), $localValues); |
Check failure
Code scanning / Psalm
PossiblyNullArgument Error
| $properties[$property->getName()] = Collection::group($results, function ($result) use ($groupColumn) { | ||
| return $result[$groupColumn]; | ||
| }); | ||
| $properties[$property->getName()] = array_map(fn($group) => array_values($group), Collection::group($results, fn ($result) => $result[$groupColumn])); |
Check failure
Code scanning / Psalm
PossiblyNullArrayOffset Error
Member
|
Looks okay. Need to update your fork from |
joshmcrae
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check for null before trying to access array. This happens when a the key for a join is nullable.
Also some minor improvements, use
array_uniquefor thein()query param to prevent us passing the same thing a hundred times toinAnd do
array_valueswhen we do the grouping so we only do it once.