fix(cli): honor skip postprocess flags#487
Open
iamstuffed wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes CLI post-processing flag handling by removing the extra CLI-level post-processing pass and relying on build_or_update_graph(...) to enforce none, minimal, and full behavior.
Changes:
- Removed the unused
_cli_post_process(...)helper and its calls frombuild/update. - Added regression tests for
build --skip-postprocessandupdate --skip-flows. - Added
pytest-asyncioto theuvdev dependency group.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
code_review_graph/cli.py |
Stops running a second post-processing pass after build/update. |
tests/test_cli.py |
Adds CLI regression tests for skip post-processing behavior. |
pyproject.toml |
Adds pytest-asyncio to dependency groups for test execution via uv. |
uv.lock |
Updates locked dev dependency metadata for pytest-asyncio. |
b8a4ca1 to
0d3a35c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the
buildandupdateCLI commands so their post-processing flags are honored.Previously, the CLI passed the selected postprocess level into
build_or_update_graph(...), but then ran the older full CLI post-processing pipeline afterward. As a result:code-review-graph build --skip-postprocessstill ran full post-processing.code-review-graph update --skip-flowsstill ran flow/community post-processing.postprocess=noneorpostprocess=minimalwhile doing more work than requested.This PR removes the extra CLI post-processing pass and relies on
build_or_update_graph(...)as the source of truth fornone,minimal, andfullpost-processing behavior.Changes
_cli_post_process(...)calls afterbuild_or_update_graph(...)._cli_post_processhelper.build --skip-postprocessupdate --skip-flowspytest-asyncioto theuvdev dependency group souv run python -m pytestinstalls the async test plugin used by the existing test suite.Validation
Result: