fix: add file_path, relative_path, and language to dead_code response#481
Open
itxaiohanglover wants to merge 1 commit into
Open
fix: add file_path, relative_path, and language to dead_code response#481itxaiohanglover wants to merge 1 commit into
itxaiohanglover wants to merge 1 commit into
Conversation
…tirth8205#447) find_dead_code() returned only 5 fields per entry while other tools like find_large_functions return richer data via node_to_dict. Add file_path, relative_path, and language to bring consistency. The 'file' key is kept for backward compatibility. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #447
find_dead_code()now returnsfile_path,relative_path, andlanguagefields per entry, consistent with other tools likefind_large_functionsfilekey is retained for backward compatibilityrootparameter is optional — when not provided,relative_pathfalls back to the absolute path (sosuggest_refactoringsand other internal callers are unaffected)Changes
code_review_graph/refactor.pyrootparam tofind_dead_code(); enriched output dict with 3 new fieldscode_review_graph/tools/refactor_tools.pyrootfrom_get_store()tofind_dead_code()tests/test_refactor.pyTest plan
test_find_dead_code_response_fields— verifiesfile_path,relative_path,language, and backward-compatfilekeytest_find_dead_code_relative_path_without_root— verifies fallback whenrootis not providedruff checkpasses with no warnings🤖 Generated with Claude Code