fix: d3.select("svg") selects legend inline SVG instead of main canvas#451
Open
wangpi26 wants to merge 1 commit into
Open
fix: d3.select("svg") selects legend inline SVG instead of main canvas#451wangpi26 wants to merge 1 commit into
wangpi26 wants to merge 1 commit into
Conversation
The legend section uses inline <svg> elements for node type icons which
appear before the main <svg id="graph-svg"> in the DOM. d3.select("svg")
matched the first inline SVG (16x16 icon) instead of the main canvas,
causing the graph to render inside the tiny legend icon.
Replace d3.select("svg") with d3.select("#graph-svg") at both
occurrences (lines 859 and 1759) to target the correct element.
Closes tirth8205#450
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the generated
graph.html, the<nav id="legend">section uses inline<svg>elements (16×16 icons) for node type legends. The main canvas<svg id="graph-svg">appears later in the DOM. The JavaScript code usesd3.select("svg")which selects the first<svg>element in the DOM — the small legend icon — causing the entire graph to be rendered inside that tiny icon.Fix
Replace
d3.select("svg")withd3.select("#graph-svg")at both occurrences incode_review_graph/visualization.py:The main canvas SVG already has
id="graph-svg"defined, so this is a minimal, safe change.Testing
code-review-graph visualizeto generategraph.htmlgraph.htmlin a browserCloses #450