compiler: add range param attr to slice/string len/cap#5162
Draft
niaow wants to merge 1 commit intotinygo-org:devfrom
Draft
compiler: add range param attr to slice/string len/cap#5162niaow wants to merge 1 commit intotinygo-org:devfrom
niaow wants to merge 1 commit intotinygo-org:devfrom
Conversation
This attaches the maximum valid len/cap to string/slice fuction parameters. The compiler can use this to: 1. Prove that index math will not overflow 2. Prove that signed and unsigned comparisons are equivalent
Member
Author
|
This is failing because the bindings changed the default LLVM version to 21 which we do not support |
aykevl
approved these changes
Apr 22, 2026
Member
aykevl
left a comment
aykevl
left a comment
There was a problem hiding this comment.
Nice optimization, thanks!
If you rebase tinygo-org/go-llvm#72 on the main branch the build failures should be fixed (see tinygo-org/go-llvm#74).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attaches the maximum valid len/cap to string/slice fuction parameters. The compiler can use this to:
This depends on tinygo-org/go-llvm#72
Closes #5147