fill out more constants for lora driver#855
Open
jwetzell wants to merge 1 commit intotinygo-org:devfrom
Open
Conversation
jwetzell
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I plan to do some work on adding a driver for the Semtech SX128x when I get my boards in here soon but figured I would start laying out some of the easy stuff that I can do without having them in hand.
This adds some basic constants to the generic lora driver
BW_400for406.25but the existing bandwidth constants don't follow that so neither did I.The SX128x chips operate in a different frequency space (2.4Ghz) but I'm not sure if there are any "standard" frequencies like the ones that seem to be defined for LoRaWAN regions. I couldn't find anything so left out adding constants for frequencies.