Fix KPI hourly granularity with previous period#208
Merged
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019c4ebf-6034-7789-a533-627df02d1097 Co-authored-by: Amp <amp@ampcode.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
alrocar
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Amp-Thread-ID: https://ampcode.com/threads/T-019c4ebf-6034-7789-a533-627df02d1097
Summary
Keep hourly time series for kpis when include_previous_period=true by aligning the date filter to the hourly range.
Add a small fixture used for verifying the hourly output.
Details
When date_from == date_to (today/yesterday), the kpis endpoint emits hourly DateTime points. The previous change filtered by current_end at midnight, which effectively trimmed the hourly series when include_previous_period=true. The filter now includes the full day so hourly rows are preserved.
Testing
Built Tinybird branch fix_kpis_hourly_prev_period (Tinybird SDK CLI)
Appended fixture data and verified hourly kpis output with previous-period metrics on the branch
Notes
Fixture used for local/branch validation: tinybird/fixtures/analytics_events.ndjson
If you don’t want to keep the fixture in the repo, I can remove it and update the PR accordingly.