Skip to content

Support multi-arg AggregateFunction types#158

Merged
gnzjgo merged 1 commit into
mainfrom
fix-aggregate-function-multi-args
May 19, 2026
Merged

Support multi-arg AggregateFunction types#158
gnzjgo merged 1 commit into
mainfrom
fix-aggregate-function-multi-args

Conversation

@gnzjgo
Copy link
Copy Markdown
Member

@gnzjgo gnzjgo commented May 18, 2026

Summary

  • Extend t.aggregateFunction to accept one or more state type validators
  • Emit AggregateFunction(func, T1, T2, ...) for multi-argument aggregate states like argMax
  • Update ClickHouse type codegen to round-trip multi-type AggregateFunction(...) definitions

Closes #157.

Verification

  • pnpm vitest run src/schema/types.test.ts src/codegen/type-mapper.test.ts
  • pnpm typecheck
  • pnpm test:run

@gnzjgo gnzjgo force-pushed the fix-aggregate-function-multi-args branch from 0ea4d29 to e0e903a Compare May 18, 2026 22:42
@gnzjgo gnzjgo requested a review from rmorehig May 18, 2026 22:45
@gnzjgo gnzjgo merged commit 341093d into main May 19, 2026
2 checks passed
@gnzjgo gnzjgo mentioned this pull request May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support AggregateFunction types with multiple argument types

2 participants