Skip to content

Fix column param metadata generation#153

Merged
rmorehig merged 2 commits into
mainfrom
fix/column-param-generation
May 7, 2026
Merged

Fix column param metadata generation#153
rmorehig merged 2 commits into
mainfrom
fix/column-param-generation

Conversation

@rmorehig
Copy link
Copy Markdown
Collaborator

@rmorehig rmorehig commented May 7, 2026

Summary

  • skip required and description keyword emission for p.column() parameters
  • keep positional default injection so p.column().optional("lastSeen") generates {{ column(orderBy, 'lastSeen') }}
  • add regression coverage for Tinybird's column() template helper behavior

Docs checked

  • Tinybird query parameter docs document column() separately as {{column(order_by, 'timestamp')}} and recommend the second positional default argument.
  • The generic description=... / required=... signature is shown for typed dynamic parameters, while column() examples do not use those kwargs.

Verification

  • pnpm vitest run src/generator/pipe.test.ts src/schema/params.test.ts
  • pnpm typecheck

@rmorehig rmorehig merged commit 9986cee into main May 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant