fix(api): include connections in deploy request body#120
Merged
rmorehig merged 2 commits intotinybirdco:mainfrom Feb 26, 2026
Merged
fix(api): include connections in deploy request body#120rmorehig merged 2 commits intotinybirdco:mainfrom
rmorehig merged 2 commits intotinybirdco:mainfrom
Conversation
Made-with: Cursor
Made-with: Cursor
Collaborator
|
Thanks for the PR! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
tinybird buildcorrectly deploys Datasources, Pipes, and Connections to the local/branch workspace.tinybird deployonly sends Datasources and Pipes to the cloud; Connections are never added to the multipart form body for/v1/deploy, so they are not deployed to the main workspace.src/api/deploy.ts, the FormData is only populated withdatasourcesandpipes. The “Add connections” loop that exists insrc/api/build.tswas missing in the deploy path.deploy.ts(after adding pipes, before the deployment cleanup step), so thatresources.connectionsare appended to the form withdata_project://and${conn.name}.connectionfilenames.build.test.tsanddeploy.test.tsto ensure that when resources include connections, both build and deploy include them in the request form data and report the correctconnectionCount.