Update CI workflow, improve PHP version handling, and refactor code for clarity. #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor code for clarity.
…tor code for clarity.
…tor code for clarity.
There was a problem hiding this comment.
Pull request overview
This pull request updates the CI workflow, improves PHP version handling, removes PHPMD tooling, and refactors code for clarity by simplifying object instantiation syntax and improving return type declarations.
Changes:
- Upgraded minimum PHP requirement from 8.3 to 8.5 and updated Docker image accordingly
- Removed PHPMD from the project and downgraded PHPUnit (12.1→11.5) and PHPStan (2.1→1.12)
- Refactored CI workflow to use artifact caching and added a help system to the Makefile
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Internal/Mappers/Object/Reflector.php | Improved return type declarations from mixed to ?object and object for better type safety |
| src/Internal/Mappers/Object/Casters/DefaultCaster.php | Simplified object instantiation by removing unnecessary parentheses |
| src/Internal/Mappers/Object/Casters/CollectionCaster.php | Simplified object instantiation by removing unnecessary parentheses |
| src/Internal/Mappers/Collection/ValueMapper.php | Simplified object instantiation by removing unnecessary parentheses |
| phpmd.xml | Removed PHPMD configuration file |
| composer.json | Updated PHP version to 8.5, downgraded testing tools, removed PHPMD, added branch alias |
| Makefile | Updated to PHP 8.5 Docker image, improved PWD detection, added comprehensive help system with color-coded output |
| .github/workflows/ci.yml | Added build job with artifact caching, improved job dependencies, standardized PHP configuration |
| .gitattributes | Removed reference to deleted phpmd.xml file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…tor code for clarity.
…tor code for clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.