Skip to content

Conversation

@tijmenbruggeman
Copy link
Collaborator

@tijmenbruggeman tijmenbruggeman commented Jan 7, 2026

Fixes the test "will only apply a conversion when images are already compressed but not converted". This test verifies that bulk optimization still converts images even if they have already been compressed.

Test script of this test

- turns off conversion
- uploads & compresses an image
- turns on conversion
- uploads an image
- uses bulk optimization to convert the first image and convert & compress the second one

The test was flaky because the network request happening in the bulk optimization script wasn't awaited and the table row therefor could not always be found in the right state.

  • modernized JavaScript to make it more readable;
  • added a test id to the table rows;
  • added an endpoint await;
  • added an set api key to ensure the test can be run individually;

@rkoopmans rkoopmans merged commit e7f8753 into tinify:master Jan 8, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants