Open
Conversation
- use this bessselnumba module everywhere. - move bessel tests to test root dir
- make steady/transient versions inherit from base - fix all plotting to accept axes - add layer kwarg to all element plot funcs
- rename ttim -> timflow/timflow.transient - rename timml to timflow/timflow.steady
- move some stuff - add docstrings - rename timml and ttim - modify imports to fs and ft - move about section - improve ttim docs structure - apply new plotting everywhere - add logo - rename example output figures - update ci - new xsections section for timflow.transient
move to one bessel module
- actually run notebooks on RTD now
Somewhat unified plotting
Contributor
|
|
- need to pass ax to the plotting function now, otherwise it ends up on a new figure
- still accepts a collection of 2 axes if orientation="both"
And add deprecation warning
Contributor
|
I noticed that in the new ReadTheDocs there are now three boxes: Steady, Transient and Bessel. I don't think Bessel should be there. That is not a package for which separate docs should exist. @dbrakenhoff can you remove that again? Or is that the effect of a separate bessel directory. If it cannot be removed for that reason, I am changing my mind and think we should move besselnumba.py back to the main directory. |
- update import statements everywhere - update element names in docs and modules - add deprecated classes for old element names
- add sep argument for plotting parameters in cross-section on same line or separated by newlines - improve plotting of hstar for transient models - add inhomogeneity names option for cross-section models - add support for plotting capzones for multiple wells at once. - add support for plotting capzones based on well names
Contributor
Author
|
@mbakker7, after adding the ttim --> timflow notebook I think this is ready for another check.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To-do before merging and releasing: