refactor(embedding): simplify to OpenAI + Ollama with O(1) character-based truncation#2
Merged
refactor(embedding): simplify to OpenAI + Ollama with O(1) character-based truncation#2
Conversation
Simplify to just OpenAI and Ollama: - OpenAI for hosted platform - Ollama for self-hosted (runs any model locally) Removes 3 dependencies: @ai-sdk/cohere, @ai-sdk/mistral, @ai-sdk/google Removes Cohere-specific providerOptions handling
- maxParallelCalls is passed through to embedMany (controls concurrent chunk requests) - Removed batchSize option (not a Vercel AI SDK option, chunking is automatic)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Truncation overhaul
js-tiktokenandmistral-tokenizer-jsdependenciestext.lengthandtext.slice()are O(1) — no event loop blockingProvider simplification
Options cleanup
maxParallelCallsto actually be passed toembedManybatchSizeoption (SDK handles chunking automatically)Why
Breaking Changes
EmbeddingProvidertype now only accepts"openai" | "ollama"batchSizefromEmbeddingOptionsTest Results