Add build ordering and mem requirements for tiles via a --tile-specifier-file optional param#71
Open
tgrigsby-sc wants to merge 23 commits intomasterfrom
Open
Add build ordering and mem requirements for tiles via a --tile-specifier-file optional param#71tgrigsby-sc wants to merge 23 commits intomasterfrom
tgrigsby-sc wants to merge 23 commits intomasterfrom
Conversation
255344d to
10b4769
Compare
10b4769 to
a4901c0
Compare
Member
|
Looks good so far. |
3cd0e4d to
87c4ba3
Compare
0818757 to
ffd4b9e
Compare
9149231 to
6d99e95
Compare
6d99e95 to
5b7e092
Compare
8ce9f99 to
1a6469d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still a WIP This works - verified manually with last tile build. I want to try one full build before I call this done which I will do next week.
--tile-specifier-fileparam tomake_meta_tiles.pythat points to an ordering fileTileSpecifierthat uses the tile specifier file to dictate ordering and memory requirements of a list of tilesenqueue_tilesto make 1 call per job totilequeue_batch_enqueueinstead of a single call.enqueue_tilesto override every job with it's requested memory numberTileSpecifiercreation exceptions by falling back to a no-op default