Skip to content

Disallow empty task groups #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukasbindreiter merged 1 commit into from
Nov 12, 2025
Merged

Disallow empty task groups #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion apis/workflows/v1/core.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,12 @@ message TaskSubmissionGroup {
// The input parameters for each task.
// We explicitly don't group the fields into a submessage and then have a single repeated field for that submessage,
// to enable packed encoding of the repeated fields.
repeated bytes inputs = 2 [(buf.validate.field).repeated.items.bytes.max_len = 2048];
repeated bytes inputs = 2 [(buf.validate.field).repeated = {
min_items: 1 // we don't allow empty submission groups
items: {
bytes: {max_len: 2048}
}
}];
// Index of the task identifier in the identifier_lookup field of the containing TaskSubmissions message
// for each task.
repeated uint64 identifier_pointers = 3;
Expand Down
6 changes: 6 additions & 0 deletions apis/workflows/v1/job.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,12 @@ option features.field_presence = IMPLICIT;

// SubmitJobRequest submits and schedules a job for execution. The job can have multiple root tasks.
message SubmitJobRequest {
option (buf.validate.message).cel = {
id: "submit_job_request.tasks_required"
message: "At least one task must be submitted."
expression: "(this.tasks != null && this.tasks.task_groups.size() > 0) || this.legacy_tasks.size() > 0"
};

// The root tasks for the job.
TaskSubmissions tasks = 5;
// The name of the job.
Expand Down