Skip to content

Remove min_length requirement on deprecated legacy tasks #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukasbindreiter merged 1 commit into from
Nov 12, 2025
Merged

Remove min_length requirement on deprecated legacy tasks #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions apis/workflows/v1/job.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,6 @@ option features.field_presence = IMPLICIT;

// SubmitJobRequest submits and schedules a job for execution. The job can have multiple root tasks.
message SubmitJobRequest {
// The root tasks for the job.
repeated SingleTaskSubmission legacy_tasks = 1 [(buf.validate.field).repeated = {
min_items: 1
max_items: 64
}];
// The root tasks for the job.
TaskSubmissions tasks = 5;
// The name of the job.
Expand All @@ -27,6 +22,15 @@ message SubmitJobRequest {
string trace_parent = 3 [(buf.validate.field).string.min_len = 1];
// Optional. The ID of the automation that submits this job.
tilebox.v1.ID automation_id = 4;

// The root tasks for the job. This field is deprecated and will be removed in the future. Kept around for backwards
// compatibility.
repeated SingleTaskSubmission legacy_tasks = 1 [
deprecated = true,
// we support more than that due to grouping and tree spawning, but we rather want to encourage users
// to update their clients to use the new field which has way less serialization overhead.
(buf.validate.field).repeated.max_items = 1000
];
}

// GetJobRequest requests details for a job.
Expand Down
14 changes: 9 additions & 5 deletions apis/workflows/v1/task.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,18 @@ message ComputedTask {
// If not set, the display message specified upon task submission will be kept.
string display = 2;
// A list of sub-tasks that the just computed task spawned.
repeated SingleTaskSubmission legacy_sub_tasks = 3 [
deprecated = true,
(buf.validate.field).repeated.max_items = 64
];
// A list of sub-tasks that the just computed task spawned.
TaskSubmissions sub_tasks = 5;
// A list of progress updates that the computed task wants to report.
repeated Progress progress_updates = 4;

// A list of sub-tasks that the just computed task spawned. This field is deprecated and will be removed in the
// future. Kept around for backwards compatibility.
repeated SingleTaskSubmission legacy_sub_tasks = 3 [
deprecated = true,
// we support more than that due to grouping and tree spawning, but we rather want to encourage users
// to update their clients to use the new field which has way less serialization overhead.
(buf.validate.field).repeated.max_items = 1000
];
}

// IdlingResponse is set in the response of a NextTaskRequest if no task was returned, indicating that the requesting
Expand Down