Skip to content

change geom_vline and geom_hline inherit.aes parameter default to NULL #6836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EvaMaeRey wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −2
Open

change geom_vline and geom_hline inherit.aes parameter default to NULL #6836

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b46d1e
geom_abline, vline, and hline default value of inherit.aes parameter …
EvaMaeRey Apr 10, 2026
c1935f1
Change inherit.aes default back to FALSE in geom_abline but not geom_…
EvaMaeRey Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions R/geom-abline-hline-vline.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,10 @@ geom_hline <- function(mapping = NULL, data = NULL,
yintercept,
na.rm = FALSE,
show.legend = NA,
inherit.aes = FALSE) {
inherit.aes = NULL) {

# if NJLL default is based on if xintercept is missing
Copy link
Copy Markdown
Contributor

@arcresu arcresu Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# if NJLL default is based on if xintercept is missing
# if NULL, default is based on whether xintercept is missing

(And same below).

inherit.aes <- inherit.aes %||% missing(yintercept)

# Act like an annotation
if (!missing(yintercept)) {
Expand Down Expand Up @@ -169,7 +172,10 @@ geom_vline <- function(mapping = NULL, data = NULL,
xintercept,
na.rm = FALSE,
show.legend = NA,
inherit.aes = FALSE) {
inherit.aes = NULL) {

# if NJLL default is based on if xintercept is missing
inherit.aes <- inherit.aes %||% missing(xintercept)

# Act like an annotation
if (!missing(xintercept)) {
Expand Down
Loading