[LOOP-5403] Fix Average Glucose Calculation in Preset Performance History#918
Open
[LOOP-5403] Fix Average Glucose Calculation in Preset Performance History#918
Conversation
nhamming
approved these changes
Mar 24, 2026
nhamming
left a comment
nhamming
left a comment
There was a problem hiding this comment.
I have a comment that should be seriously considered. But approving just in case I have a misunderstanding.
| var averageGlucose: LoopQuantity { | ||
| LoopQuantity( | ||
| let valuesAfterStart = allGlucoseValues.dropFirst() | ||
| guard !valuesAfterStart.isEmpty else { return LoopQuantity(unit: .milligramsPerDeciliter, doubleValue: 0) } |
There was a problem hiding this comment.
hm... should this be allowed to return an optional instead of 0? A glucose value of 0 is not biologically possible.
Not sure of the use of this averaging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://tidepool.atlassian.net/browse/LOOP-5403