Skip to content

Conversation

@FrankTheBoxMonster
Copy link
Collaborator

There was a separate command line being ran as part of release that was explicitly overriding to .net 7 and I didn't catch that one when updating everything else to .net 8 previously

There was a separate command line being ran as part of release that was explicitly overriding to .net 7 and I didn't catch that one when updating everything else to .net 8 previously
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai
Copy link

coderabbitai bot commented Dec 15, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The release workflow in .github/workflows/release.yml has been updated to target .NET 8.0 instead of .NET 7.0 for the published binary. The Build step now specifies net8.0 as the target framework. No changes were made to the build logic, conditionals, release name construction, or post-build steps. The rest of the release workflow remains unchanged.

Possibly related PRs

  • thunderstore-cli#110: Also updates the release workflow to migrate from .NET 7 to .NET 8 targeting framework
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-actions-dotnet-version-for-real-this-time

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ae3656c and b51bb87.

📒 Files selected for processing (1)
  • .github/workflows/release.yml (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@FrankTheBoxMonster FrankTheBoxMonster merged commit a6ee9f2 into master Dec 15, 2025
4 of 6 checks passed
@FrankTheBoxMonster FrankTheBoxMonster deleted the fix-actions-dotnet-version-for-real-this-time branch December 15, 2025 20:39
@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 5.46%. Comparing base (ae3656c) to head (b51bb87).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #114   +/-   ##
======================================
  Coverage    5.46%   5.46%           
======================================
  Files          41      41           
  Lines        2416    2416           
  Branches      238     238           
======================================
  Hits          132     132           
  Misses       2281    2281           
  Partials        3       3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants