Skip to content

Conversation

@FrankTheBoxMonster
Copy link
Collaborator

Changing '7' to '8' apparently didn't do anything, docs only ever mention using '8.0.x' so going to try that instead

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai
Copy link

coderabbitai bot commented Dec 15, 2025

Walkthrough

This pull request modifies the dotnet-version specification in .github/workflows/release.yml, changing from '8' to 8.0.x in the Setup .NET action steps. This affects two jobs in the release workflow (platform-binary and nupkg), refining the .NET 8.x SDK matching behavior. No changes are made to build, install, or release step logic.

Possibly related PRs

  • thunderstore-cli#110: Modifies the same dotnet-version configuration in release.yml workflows, transitioning from .NET 7 to 8, providing context for version management strategy across similar workflows.

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Update release.yml' is vague and generic, failing to convey what change was made or why—it simply names the file being modified. Use a more descriptive title like 'Update .NET version format in release.yml to 8.0.x' to clarify the specific change and its purpose.
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The description explains the motivation and specific change: updating the dotnet-version from '7' to '8' wasn't working, so switching to '8.0.x' per documentation recommendations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-actions-dotnet-again

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ae3656c and 1405e0b.

📒 Files selected for processing (1)
  • .github/workflows/release.yml (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build and test windows-latest
🔇 Additional comments (1)
.github/workflows/release.yml (1)

57-61: Aligns with setup-dotnet docs; should track latest 8.0 patch

Switching to dotnet-version: 8.0.x in both jobs brings the workflow in line with the documented pattern and will keep picking the latest 8.0 SDK, which is generally what you want. Given the project still targets net7.0, building with an 8.0 SDK is normally supported and should be safe.

Please double-check the current actions/setup-dotnet@v4 docs and confirm via a test/tagged run that the workflow now installs the expected SDK version (e.g., by echoing dotnet --info in a temporary step).

Also applies to: 100-104


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 5.46%. Comparing base (ae3656c) to head (1405e0b).

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #113   +/-   ##
======================================
  Coverage    5.46%   5.46%           
======================================
  Files          41      41           
  Lines        2416    2416           
  Branches      238     238           
======================================
  Hits          132     132           
  Misses       2281    2281           
  Partials        3       3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@FrankTheBoxMonster
Copy link
Collaborator Author

FrankTheBoxMonster commented Dec 15, 2025

nvm this isn't the actual problem, figured out what is though so resubmitting with that instead (there's a separate command line being ran that explicitly overrides to using .net 7 and I didn't catch it when updating previously)

@FrankTheBoxMonster FrankTheBoxMonster deleted the fix-actions-dotnet-again branch December 15, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants