chore(core): trim stale comments in DBWrapper and SingletonWorkDataWorkLoad#538
Merged
Conversation
…rkLoad DBWrapper#deviceSummary: drop the "previously the last loop iteration would NPE" note — the code already short-circuits on isEmpty and picks the first summary as the comparison base, which is self-explanatory. SingletonWorkDataWorkLoad#getOneBatch: drop the "(defect #3)" PR back-reference and the redundant single-threaded equivalence note from the sensor-cursor comment, keep the actionable WHY (two independent counters race the device/sensor pairing). No behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two stale-comment cleanups in core, surfaced in a Staff-Engineer-style review of the recent #533–#537 batch. No behavior change.
DBWrapper#deviceSummary— drop the "previously the last loop iteration would NPE" note. The code now short-circuits ondeviceSummaries.isEmpty()and picks[0]as the comparison base; the historical note no longer adds information.SingletonWorkDataWorkLoad#getOneBatch— drop the(defect #3)PR back-reference and the single-threaded equivalence trivia from the sensor-cursor comment. Keep the actionable WHY: two independent counters can be raced between the device and sensor reads, mis-pairing them.Both comments hit project conventions in
CLAUDE.md:Test plan
mvn -pl core spotless:checkmvn -pl core compile