map mycelium to twin identity by Omarabdul3ziz · Pull Request #1037 · threefoldtech/tfchain

Omarabdul3ziz · 2025-05-26T10:53:38Z

add storage map from myc->twin
add setter method to update the storage which emit TwinMyceliumPkSet event
update rs/ts/go clients with setter/getter methods

- add storage map from myc->twin - add setter method to update the storage which emit TwinMyceliumPkSet event - update rs/ts/go clients with setter/getter methods

Copilot

Pull Request Overview

This PR introduces a mapping between a mycelium public key and a twin identity by adding new storage, extrinsics, events, and updating client libraries.

Adds a new storage map (MyceliumTwin) and setter extrinsic (set_mycelium_twin) that emits the MyceliumTwinUpdated event.
Updates weights, benchmarking, and clients in Rust, JavaScript, and Go to support the new mapping functionality.

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
substrate-node/pallets/pallet-tfgrid/src/weights.rs	Added weight calculation for the new extrinsic.
substrate-node/pallets/pallet-tfgrid/src/twin.rs	Introduced the internal setter _set_mycelium_twin with event emission.
substrate-node/pallets/pallet-tfgrid/src/lib.rs	Added storage definition and new extrinsic for mapping.
substrate-node/pallets/pallet-tfgrid/src/benchmarking.rs	Added benchmarks for the new extrinsic.
scripts/activate/man.go	Updated activation script (no direct mapping changes).
scripts/activate/go.mod	Added dependency changes for the activation module.
clients/tfchain-client-rs/*	Updated runtime client functions for setting/getting the mapping.
clients/tfchain-client-js/*	Updated twin module and client to support the new extrinsic.
clients/tfchain-client-go/*	Added new functions to map the mycelium public key to a twin.
clients/tfchain-client-go/events.go	Introduced the event struct MyceliumTwinUpdated.

Comments suppressed due to low confidence (1)

substrate-node/pallets/pallet-tfgrid/src/twin.rs:412

[nitpick] Consider renaming '_set_mycelium_twin' to a name without a leading underscore (e.g. 'set_mycelium_twin_inner') since it is a public function. This helps clarify its intended internal usage and avoids confusion with private functions.

pub fn _set_mycelium_twin(

sameh-farouk · 2025-06-11T09:11:15Z

substrate-node/pallets/pallet-tfgrid/src/weights.rs

+		Weight::from_parts(12_053_000, 3852)
+			.saturating_add(RocksDbWeight::get().reads(1_u64))
+			.saturating_add(RocksDbWeight::get().writes(1_u64))
+	}


This file shouldn't be manually updated

sameh-farouk · 2025-06-11T09:15:23Z

scripts/activate/man.go

+
+	// Step 3: Create Alice's identity for sending tokens
+	fmt.Println("Setting up Alice's identity for token transfer...")
+	aliceIdentity, err := substrate.NewIdentityFromSr25519Phrase("//Alice")


What is this script intended for?
Unless this is for a local setup, it won't work. Alice is poor(has nothing) on our dev networks

sameh-farouk · 2025-06-11T09:24:08Z

substrate-node/pallets/pallet-tfgrid/src/lib.rs

+    pub type MyceliumTwin<T: Config> = StorageMap<
+        _,
+        Blake2_128Concat,
+        MyceliumPkInput, // key is mycelium pk


MyceliumPkInput > MyceliumPk

sameh-farouk · 2025-06-11T09:26:21Z

substrate-node/pallets/pallet-tfgrid/src/lib.rs


+    #[pallet::storage]
+    #[pallet::getter(fn get_mycelium_twin)]
+    pub type MyceliumTwin<T: Config> = StorageMap<


MyceliumTwin > TwinIdByMyceliumPk

sameh-farouk · 2025-06-11T09:27:57Z

substrate-node/pallets/pallet-tfgrid/src/lib.rs

    >;

+    #[pallet::storage]
+    #[pallet::getter(fn get_mycelium_twin)]


get_mycelium_twin > twin_id_by_mycelium_pubkey

sameh-farouk · 2025-06-11T09:44:17Z

substrate-node/pallets/pallet-tfgrid/src/lib.rs

+
+        #[pallet::call_index(40)]
+        #[pallet::weight(<T as Config>::WeightInfo::set_mycelium_twin())]
+        pub fn set_mycelium_twin(


set_mycelium_twin > set_twin_mycelium_pk

sameh-farouk · 2025-06-11T09:47:38Z

substrate-node/pallets/pallet-tfgrid/src/lib.rs

+        pub fn set_mycelium_twin(
+            origin: OriginFor<T>,
+            mycelium_pk: MyceliumPkInput,
+            twin_id: u32,


Do we need to pass this twin ID? At the end, we use the sender account's twin to update the pk?

sameh-farouk · 2025-06-11T09:50:45Z

substrate-node/pallets/pallet-tfgrid/src/twin.rs

+        ensure!(twin.account_id == account_id, Error::<T>::UnauthorizedToUpdateTwin);
+
+        // Store the mapping
+        MyceliumTwin::<T>::insert(&mycelium_pk, twin_id);


Could we implement some form of validation?

sameh-farouk · 2025-06-11T09:51:43Z

substrate-node/pallets/pallet-tfgrid/src/lib.rs

+
+        #[pallet::call_index(40)]
+        #[pallet::weight(<T as Config>::WeightInfo::set_mycelium_twin())]
+        pub fn set_mycelium_twin(


Please add tests for the new call

sameh-farouk · 2025-06-11T09:59:22Z

substrate-node/pallets/pallet-tfgrid/src/lib.rs

        TwinEntityRemoved(u32, u32),
        TwinDeleted(u32),
        TwinAccountBounded(u32, T::AccountId),
+        MyceliumTwinUpdated(MyceliumPkInput, u32),


Since MyceliumPk belongs to a twin

MyceliumTwinUpdated > TwinMyceliumPkUpdated

sameh-farouk · 2025-06-11T10:17:44Z

clients/tfchain-client-go/twin.go

+//
+// Returns:
+//   - error: nil on success, error on failure
+func (s *Substrate) SetMyceliumTwin(identity Identity, myceliumPK string, twinID uint32) error {


Could you add tests to the client

sameh-farouk · 2025-06-11T10:20:26Z

clients/tfchain-client-rs/src/runtimes/current.rs

        .await?)
 }
+
+pub async fn set_mycelium_twin(


Since you are updating the rs client, you need to re-generate the client scale file

xmonader · 2025-06-11T10:21:12Z

I don't believe we should proceed with this

sameh-farouk · 2025-06-29T12:51:23Z

I converted this PR to a draft till we have a final consensus.
@Omarabdul3ziz Please discuss with Thabet and close the PR if it is no longer needed.

Omarabdul3ziz mentioned this pull request May 26, 2025

openRPC based APIs threefoldtech/zos#2346

Open

Omarabdul3ziz force-pushed the development_TwinMycPK branch 3 times, most recently from b557493 to 3fd0ab0 Compare May 29, 2025 14:30

Omarabdul3ziz added 3 commits May 31, 2025 05:03

feat: add mapping from mycelium identity to twin identity

10960d0

- add storage map from myc->twin - add setter method to update the storage which emit TwinMyceliumPkSet event - update rs/ts/go clients with setter/getter methods

update map name/methods and clients

e2c5f90

add helper account acitvation script

e325c9f

Omarabdul3ziz force-pushed the development_TwinMycPK branch from 3fd0ab0 to e325c9f Compare June 2, 2025 15:33

Omarabdul3ziz changed the title ~~update twin with myc pk~~ map mycelium to twin identity Jun 2, 2025

Omarabdul3ziz marked this pull request as ready for review June 2, 2025 16:34

Omarabdul3ziz requested review from LeeSmet and sameh-farouk as code owners June 2, 2025 16:34

This was referenced Jun 2, 2025

init messenger threefoldtech/tfgrid-sdk-go#1370

Open

mycelium messaging integration threefoldtech/zosbase#26

Open

Omarabdul3ziz requested a review from Copilot June 3, 2025 09:35

Copilot AI reviewed Jun 3, 2025

View reviewed changes

This was referenced Jun 3, 2025

integrate mycelium messaging subsystem threefoldtech/zos#2570

Open

add myceliumrx module in zoslight threefoldtech/zoslight#55

Open

sameh-farouk reviewed Jun 11, 2025

View reviewed changes

sameh-farouk marked this pull request as draft June 29, 2025 12:47

sameh-farouk marked this pull request as ready for review July 3, 2025 10:36

sameh-farouk marked this pull request as draft July 3, 2025 10:43

Conversation

Omarabdul3ziz commented May 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sameh-farouk Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xmonader commented Jun 11, 2025

Uh oh!

sameh-farouk commented Jun 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Omarabdul3ziz commented May 26, 2025 •

edited

Loading

sameh-farouk Jun 11, 2025 •

edited

Loading