[pull] master from kevoreilly:master#438
Merged
pull[bot] merged 10 commits intothreatcode:masterfrom Mar 11, 2026
Merged
Conversation
Spawns a dedicated Python process per VM, each with its own gevent event loop on a unique port, bypassing GIL serialization of result uploads across concurrent analyses. Enabled via multiworker=yes in cuckoo.conf [resultserver] section; default off preserves existing single-port behavior unchanged. - ResultServerWorkerProcess: multiprocessing.Process per VM - SingleVMResultServerWorker: gevent server reading task_id from shared multiprocessing.Value - Auto-assigns sequential ports (base_port + index) to machines - analysis_manager rooter calls use machine.resultserver_port instead of global config port for correct per-VM firewall rules
- Add task_id re-check after negotiate_protocol() to prevent results from being associated with wrong task if cancelled during I/O - Remove unused task_id parameter from clear_task()
The stuck-VM killer calls stop_machine() which triggers set_machine_status() via _status()/set_status(), causing SQLAlchemy autobegin outside any transaction block. The next session.begin() then fails with "A transaction is already begun", crashing the scheduler and leaving all VMs stuck in poweroff. - Wrap stop_machine() in the stuck-VM monitor with session.begin() - Move try/except outside the begin() block in the main loop to let the context manager handle rollback naturally (the old manual rollback() + return pattern corrupted session state) - Make shutdown_machinery() resilient to leftover transaction state - Set machine status to poweroff on unlock_machine()
Add multi-worker ResultServer: one process per VM
Fix on-demand subfile updates and handle related oversized Mongo writes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )