SCAL-288229 Update ListPageColumns enum to use Favorites and add Verified

[shivam-kumar-ts]

STILL WORKING FIRST CHNAGE IN TSA THEN MERGE THIS PR

[mnk-blr]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[gemini-code-assist]

Summary of Changes

Hello @shivam-kumar-ts, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the ListPageColumns enumeration within src/types.ts. It standardizes the naming convention for the 'favorite' column to 'Favorites' while maintaining backward compatibility through deprecation. Additionally, it introduces a new 'Verified' column, expanding the available options for configuring list page displays. These changes aim to enhance clarity and extend functionality for column management.

Highlights

• Enum Member Renaming: The ListPageColumns.Favourite enum member has been renamed to ListPageColumns.Favorites to improve naming consistency.
• Backward Compatibility: The original ListPageColumns.Favourite member has been marked as deprecated and now aliases to ListPageColumns.Favorites, ensuring existing code continues to function without immediate breakage.
• New Enum Member: A new enum member, ListPageColumns.Verified, has been added to support the display of a 'Verified badge/column' on list pages.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/thoughtspot/visual-embed-sdk/@thoughtspot/visual-embed-sdk@398

commit: 8808f2b

[gemini-code-assist]

Code Review

This pull request updates the ListPageColumns enum. It renames Favourite to Favorites for consistency with American English spelling, while maintaining backward compatibility by deprecating the old member. It also adds a new Verified column option. The changes are generally good, but I have one suggestion regarding the string value of the new Favorites enum member to improve consistency.

[gemini-code-assist]

While the approach of renaming Favourite to Favorites and keeping the old member for backward compatibility is great, there's an inconsistency between the new member name (Favorites) and its string value ('FAVOURITE').

If the backend can be updated to accept 'FAVORITES', it would be more consistent to change the value as well. To do this without breaking existing clients using Favourite, you could assign the old value explicitly to the deprecated member.

If the backend cannot be changed and must receive 'FAVOURITE', then the current implementation is a valid approach, although the inconsistency remains. Please confirm if the backend dependency prevents aligning the value.

Suggested change

	Favorites = 'FAVOURITE',
	/**
	* @deprecated Use {@link ListPageColumns.Favorites} instead.
	*/
	Favourite = Favorites,
	Favorites = 'FAVORITES',
	/**
	* @deprecated Use {@link ListPageColumns.Favorites} instead.
	*/
	Favourite = 'FAVOURITE',

[utsavkapoor]

We should add Favorites in scaligent as well and then update everything here to go to Favorites and have backward compatibility in scaligent

[utsavkapoor]

We should add Favorites in scaligent as well and then update everything here to go to Favorites and have backward compatibility in scaligent

[sonar-prod-ts]

SonarQube Quality Gate

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication