Skip to content

Conversation

@balakrishna-moravineni
Copy link
Collaborator

No description provided.

@balakrishna-moravineni balakrishna-moravineni requested a review from a team as a code owner December 18, 2025 08:11
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @balakrishna-moravineni, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new action type within the system's core types, specifically to manage the 'Data model instructions' functionality in the Spotter interface. This enhancement provides greater control over UI elements for embedded applications, allowing developers to customize the user experience by enabling or disabling access to data model instructions.

Highlights

  • New Action Enum Member: A new enum member, DataModelInstructionsSpotter, has been added to the Action enum in src/types.ts.
  • Purpose of New Action: This new action is designed to control the visibility of the 'Data model instructions' button on the Spotter interface, allowing for programmatic hiding or showing of this feature.
  • Documentation and Versioning: The new enum member includes comprehensive JSDoc comments, an example usage (hiddenAction: [Action.DataModelInstructionsSpotter]), and specifies its availability from SDK version 1.45.0 and ThoughtSpot Cloud 26.3.0.cl.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@mnk-blr
Copy link
Collaborator

mnk-blr commented Dec 18, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new embedAction for dataModelInstructionsSpotter to the Action enum. The change is well-documented. My only feedback is a minor suggestion to maintain alphabetical order within the enum for better code readability and consistency.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 18, 2025

Open in StackBlitz

npm i https://pkg.pr.new/thoughtspot/visual-embed-sdk/@thoughtspot/visual-embed-sdk@394

commit: 1e14692

@sonar-prod-ts
Copy link

sonar-prod-ts bot commented Dec 21, 2025

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants