SCAL-287989 hidePrerender fix

[yinstardev]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @yinstardev, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a fix for the hidePrerender functionality within the AppEmbed class. The change ensures that when the pre-render component is hidden, associated lazy load events are correctly unregistered, preventing potential resource issues and ensuring a more robust application state.

Highlights

• New Method: A new public method, hidePreRender(), has been added to the AppEmbed class.
• Event Cleanup: The new hidePreRender() method now explicitly calls unregisterLazyLoadEvents() to ensure proper cleanup before invoking the superclass's hidePreRender() method.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[mnk-blr]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[gemini-code-assist]

Code Review

This pull request introduces an override for the hidePreRender method in the AppEmbed class. The new method correctly calls unregisterLazyLoadEvents to clean up event listeners specific to AppEmbed before calling the parent's hidePreRender method. My review includes one high-severity finding related to a potential memory leak in the unregisterLazyLoadEvents method, which is now being called by the newly added code. Additionally, no new tests have been added to verify the behavior of the new hidePreRender method. It would be beneficial to add a unit test to src/embed/app.spec.ts to ensure unregisterLazyLoadEvents is called and that the event listeners are correctly removed. This could also help confirm the fix for the memory leak.

[gemini-code-assist]

The unregisterLazyLoadEvents method has a bug that will cause a memory leak. The scroll event listener is registered with useCapture: true in registerLazyLoadEvents (line 1056), but unregisterLazyLoadEvents attempts to remove it without specifying useCapture: true (line 1063). For removeEventListener to work correctly, it must be called with the same arguments as addEventListener. Please update unregisterLazyLoadEvents to correctly remove the listener.

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/thoughtspot/visual-embed-sdk/@thoughtspot/visual-embed-sdk@389

commit: 5dda319

[sonar-prod-ts]

SonarQube Quality Gate

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication