Skip to content

Conversation

@sastaachar
Copy link
Contributor

No description provided.

@sastaachar sastaachar requested a review from a team as a code owner December 5, 2025 07:09
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @sastaachar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the existing documentation within the src/types.ts file. The changes include a small grammatical correction to improve readability and an update to code examples for the LiveboardEmbed component, ensuring that the provided configuration snippets are accurate and up-to-date with the current API usage for intercepting URLs.

Highlights

  • Documentation Typo Fix: Corrected a minor grammatical error in the JSDoc for the EmbedEvent enum, specifically within the description of intercepting search execution.
  • API Example Update: Updated code examples for LiveboardEmbed configuration by removing the enableApiIntercept: true property, ensuring the documentation reflects the current and correct way to configure API interception.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@mnk-blr
Copy link
Collaborator

mnk-blr commented Dec 5, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@sonar-prod-ts
Copy link

sonar-prod-ts bot commented Dec 5, 2025

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 5, 2025

Open in StackBlitz

npm i https://pkg.pr.new/thoughtspot/visual-embed-sdk/@thoughtspot/visual-embed-sdk@370

commit: 3d4a051

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request contains documentation fixes. I've provided a suggestion to correct a code example that contained an invalid value, in addition to removing the deprecated property as intended by this PR. The other changes look good.

Comment on lines 6211 to 6212
* interceptUrls: [InterceptedApiType.DATA],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Removing the deprecated enableApiIntercept flag is correct. However, the example still uses InterceptedApiType.DATA, which appears to be an invalid value for URL interception. It will be treated as a literal string 'DATA', which is likely not the intended behavior. The suggestion below removes the deprecated flag and replaces DATA with LiveboardData to make the example correct.

Suggested change
* interceptUrls: [InterceptedApiType.DATA],
* interceptUrls: [InterceptedApiType.LiveboardData],

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants