SCAL-276467 Added actions for object publishing feature #363
Conversation
Summary of ChangesHello @nikhil-saini-ts, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates new actions into the system to enable and manage the object publishing feature. It provides distinct actions for initiating publishing, modifying existing publishing settings, and revoking publication for various content types such as Liveboards, Answers, and Models, thereby expanding the control over content lifecycle and visibility. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces new actions (Publish, ManagePublishing, Unpublish) for the object publishing feature. The changes are well-documented, but I found a minor typo in the JSDoc examples for all new actions. I've suggested a fix to correct hiddenAction to hiddenActions to align with the SDK's API and prevent confusion for developers.
src/types.ts
Outdated
| * hiddenAction: [Action.Publish] | ||
| * disabledActions: [Action.Publish] | ||
| * ``` | ||
| * @version SDK: 1.44.0 | ThoughtSpot Cloud: 26.2.0.cl | ||
| */ | ||
| Publish = 'publish', | ||
| /** | ||
| * The **Manage Publishing** action for Liveboards, Answers and Models. | ||
| * Opens the same publishing modal as the **Publish** action. | ||
| * Appears as a child action to the **Publish** action if the | ||
| * object is already published. | ||
| * @example | ||
| * ```js | ||
| * hiddenAction: [Action.ManagePublishing] | ||
| * disabledActions: [Action.ManagePublishing] | ||
| * ``` | ||
| * @version SDK: 1.44.0 | ThoughtSpot Cloud: 26.2.0.cl | ||
| */ | ||
| ManagePublishing = 'managePublishing', | ||
| /** | ||
| * The **Unpublish** action for Liveboards, Answers and Models. | ||
| * Opens the unpublishing modal. Appears as a child action to | ||
| * the **Publish** action if the object is already published. | ||
| * @example | ||
| * ```js | ||
| * hiddenAction: [Action.Unpublish] | ||
| * disabledActions: [Action.Unpublish] |
There was a problem hiding this comment.
There's a typo in the JSDoc examples for the new actions. The property should be hiddenActions (plural) instead of hiddenAction (singular) to match the BaseViewConfig interface.
* hiddenActions: [Action.Publish]
* disabledActions: [Action.Publish]
* ```
* @version SDK: 1.44.0 | ThoughtSpot Cloud: 26.2.0.cl
*/
Publish = 'publish',
/**
* The **Manage Publishing** action for Liveboards, Answers and Models.
* Opens the same publishing modal as the **Publish** action.
* Appears as a child action to the **Publish** action if the
* object is already published.
* @example
* ```js
* hiddenActions: [Action.ManagePublishing]
* disabledActions: [Action.ManagePublishing]
* ```
* @version SDK: 1.44.0 | ThoughtSpot Cloud: 26.2.0.cl
*/
ManagePublishing = 'managePublishing',
/**
* The **Unpublish** action for Liveboards, Answers and Models.
* Opens the unpublishing modal. Appears as a child action to
* the **Publish** action if the object is already published.
* @example
* ```js
* hiddenActions: [Action.Unpublish]
* disabledActions: [Action.Unpublish]
nikhil-saini-ts
force-pushed
the
SCAL-276467
branch
from
2312e3d to
8651524
Compare
commit: |
nikhil-saini-ts
force-pushed
the
SCAL-276467
branch
from
8651524 to
9bf5502
Compare
|
SonarQube Quality Gate
|
This update adds new action enums to support the updated publishing workflow. The changes introduce Publish, ManagePublishing, and Unpublish actions for Liveboards, Answers, and Models, along with a new Parameterise action for Tables and Connections.