Upgrade golang to 1.26, and please plugins to latest

.circleci/config.yml

@@ -3,7 +3,7 @@ jobs:
    build-alpine:
      working_directory: ~/please
      docker:
-       - image: ghcr.io/thought-machine/please_alpine:20250318
+       - image: ghcr.io/thought-machine/please_alpine:20260318
      resource_class: large
      environment:
        PLZ_ARGS: "--profile ci --profile alpine --exclude no-musl"
@@ -43,7 +43,7 @@ jobs:
    build-linux:
      working_directory: ~/please
      docker:
-       - image: ghcr.io/thought-machine/please_ubuntu:20250318
+       - image: ghcr.io/thought-machine/please_ubuntu:20260318
      resource_class: large
      environment:
        PLZ_ARGS: "--profile ci"
@@ -91,7 +91,7 @@ jobs:
    build-linux-alt:
      working_directory: ~/please
      docker:
-       - image: ghcr.io/thought-machine/please_ubuntu_alt:20250318
+       - image: ghcr.io/thought-machine/please_ubuntu_alt:20260318
      resource_class: large
      environment:
        PLZ_ARGS: "-c cover --profile ci-alt"
@@ -154,7 +154,7 @@ jobs:
    build-freebsd:
      working_directory: ~/please
      docker:
-       - image: ghcr.io/thought-machine/please_freebsd_builder:20250318
+       - image: ghcr.io/thought-machine/please_freebsd_builder:20260318
      resource_class: large
      steps:
        - checkout
@@ -180,7 +180,7 @@ jobs:
    build-linux-arm64:
      working_directory: ~/please
      docker:
-       - image: ghcr.io/thought-machine/please_ubuntu:20250318
+       - image: ghcr.io/thought-machine/please_ubuntu:20260318
      resource_class: large
      steps:
        - checkout
@@ -250,7 +250,7 @@ jobs:
    test-rex:
      working_directory: ~/please
      docker:
-       - image: ghcr.io/thought-machine/please_ubuntu:20250318
+       - image: ghcr.io/thought-machine/please_ubuntu:20260318
      resource_class: xlarge
      steps:
        - checkout
@@ -267,7 +267,7 @@ jobs:
    test-http-cache:
      working_directory: ~/please
      docker:
-       - image: ghcr.io/thought-machine/please_ubuntu:20250318
+       - image: ghcr.io/thought-machine/please_ubuntu:20260318
      resource_class: large
      steps:
        - checkout
@@ -283,7 +283,7 @@ jobs:
    # Releases to github and homebrew
    release:
      docker:
-       - image: ghcr.io/thought-machine/please_ubuntu:20250318
+       - image: ghcr.io/thought-machine/please_ubuntu:20260318
      environment:
        GOOGLE_APPLICATION_CREDENTIALS=/tmp/service_account.json
      steps:
@@ -298,7 +298,7 @@ jobs:
    # Releases the docs and the binaries to gs for please.build and get.please.build
    release-gs:
      docker:
-       - image: ghcr.io/thought-machine/please_ubuntu:20250318
+       - image: ghcr.io/thought-machine/please_ubuntu:20260318
      environment:
        GOOGLE_APPLICATION_CREDENTIALS=/tmp/service_account.json
      steps:
@@ -310,7 +310,7 @@ jobs:
    # Runs a benchmarking test and records some performance results.
    perf-test:
      docker:
-       - image: ghcr.io/thought-machine/please_ubuntu:20250318
+       - image: ghcr.io/thought-machine/please_ubuntu:20260318
      environment:
        GOOGLE_APPLICATION_CREDENTIALS=/tmp/service_account.json
      resource_class: xlarge  # Want to run these tests with a significant amount of parallelism

.github/workflows/golangci-lint.yml

@@ -14,8 +14,8 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-go@v5
         with:
-          go-version: '^1.24'
+          go-version: '^1.26'
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v8
         with:
-          version: v2.2
+          version: v2.11

docs/codelabs/using_plugins.md

@@ -126,7 +126,7 @@ help [language]`.
 ```python
 plugin_repo(
   name = "go",
-  revision = "v1.17.2",
+  revision = "v1.29.0",
   plugin = "go-rules",
   owner = "please-build",
 )

go.mod

@@ -1,6 +1,6 @@
 module github.com/thought-machine/please
 
-go 1.24.0
+go 1.26.1
 
 require (
 	cloud.google.com/go/longrunning v0.5.5

plugins/BUILD

@@ -1,7 +1,7 @@
 plugin_repo(
     name = "go",
     plugin = "go-rules",
-    revision = "v1.21.5",
+    revision = "v1.29.0",
 )
 
 plugin_repo(
@@ -13,11 +13,11 @@ plugin_repo(
 plugin_repo(
     name = "shell",
     plugin = "shell-rules",
-    revision = "v0.1.1",
+    revision = "v0.2.1",
 )
 
 plugin_repo(
     name = "python",
     plugin = "python-rules",
-    revision = "v1.7.4",
+    revision = "v1.14.0",
 )

src/please.go

@@ -1149,7 +1149,7 @@ func Please(targets []core.BuildLabel, config *core.Configuration, shouldBuild,
 	}
 	state.TestSequentially = opts.Test.Sequentially || opts.Cover.Sequentially // Similarly here.
 	state.TestArgs = opts.Test.StateArgs
-	state.NeedCoverage = opts.Cover.active
+	state.NeedCoverage = opts.Cover.active || config.Build.Config == "cover"
 	state.NeedBuild = shouldBuild
 	state.NeedTests = shouldTest
 	state.NeedRun = !opts.Run.Args.Target.IsEmpty() || len(opts.Run.Parallel.PositionalArgs.Targets) > 0 || len(opts.Run.Sequential.PositionalArgs.Targets) > 0 || !opts.Exec.Args.Target.IsEmpty() || len(opts.Exec.Sequential.Args.Targets) > 0 || len(opts.Exec.Parallel.Args.Targets) > 0 || opts.Tool.Args.Tool != "" || debug

test/audit/test_repo/BUILD.test

@@ -1,5 +1,5 @@
 plugin_repo(
     name = "go",
     plugin = "go-rules",
-    revision = "v1.21.5",
+    revision = "v1.29.0",
 )

test/entry_point/test_repo/plugins/BUILD_FILE

@@ -1,11 +1,11 @@
 plugin_repo(
     name = "shell",
     plugin = "shell-rules",
-    revision = "v0.1.1",
+    revision = "v0.2.1",
 )
 
 plugin_repo(
     name = "go",
     plugin = "go-rules",
-    revision = "v1.21.5",
+    revision = "v1.29.0",
 )

test/include/test_repo/plugins/BUILD_FILE

@@ -1,5 +1,5 @@
 plugin_repo(
     name = "shell",
     plugin = "shell-rules",
-    revision = "v0.1.1",
+    revision = "v0.2.1",
 )

test/plugins/self_referencing_plugin/plugins/BUILD_FILE

@@ -1,5 +1,5 @@
 plugin_repo(
     name = "shell",
     plugin = "shell-rules",
-    revision = "v0.1.1",
+    revision = "v0.2.1",
 )

test/plugins/test_repo/plugins/BUILD_FILE

@@ -6,5 +6,5 @@ plugin_repo(
 plugin_repo(
     name = "go",
     plugin = "go-rules",
-    revision = "v1.21.5",
+    revision = "v1.29.0",
 )

test/plz_exec/test_repo/plugins/BUILD_FILE

@@ -6,5 +6,5 @@ plugin_repo(
 plugin_repo(
     name = "go",
     plugin = "go-rules",
-    revision = "v1.21.5",
+    revision = "v1.29.0",
 )

test/plz_run/test_repo/plugins/BUILD_FILE

@@ -1,5 +1,5 @@
 plugin_repo(
     name = "shell",
     plugin = "shell-rules",
-    revision = "v0.1.1",
+    revision = "v0.2.1",
 )

test/preloaded_subinc/test_repo/plugins/BUILD_FILE

@@ -1,7 +1,7 @@
 plugin_repo(
     name = "shell",
     plugin = "shell-rules",
-    revision = "v0.1.1",
+    revision = "v0.2.1",
 )
 
 plugin_repo(

test/proto_plugin/test_repo/plugins/BUILD_FILE

@@ -6,7 +6,7 @@ plugin_repo(
 plugin_repo(
     name = "go",
     plugin = "go-rules",
-    revision = "v1.21.5",
+    revision = "v1.29.0",
 )
 
 plugin_repo(

third_party/go/BUILD

@@ -5,14 +5,14 @@ package(default_visibility = ["PUBLIC"])
 go_toolchain(
     name = "toolchain",
     hashes = [
-        "fde05d84f7f64c8d01564f299ea1897fe94457d20d8d9054200ac1f8ae1c2bc3",  # go1.24.10.darwin-amd64.tar.gz
-        "71c70841bcdadf4b5d2f7c0f099952907969f25235663622a47d6f2233ad39aa",  # go1.24.10.darwin-arm64.tar.gz
-        "cb917b64aa4a407ed3310b397cc4dca10f0a3e2b0dd184ed74164ceaeab2625e",  # go1.24.10.freebsd-amd64.tar.gz
-        "dd52b974e3d9c5a7bbfb222c685806def6be5d6f7efd10f9caa9ca1fa2f47955",  # go1.24.10.linux-amd64.tar.gz
-        "94a99dae43dab8a3fe337485bbb89214b524285ec53ea02040514b0c2a9c3f94",  # go1.24.10.linux-arm64.tar.gz
+        "65773dab2f8cc4cd23d93ba6d0a805de150ca0b78378879292be0b903b8cdd08",  # go1.26.1.darwin-amd64.tar.gz
+        "353df43a7811ce284c8938b5f3c7df40b7bfb6f56cb165b150bc40b5e2dd541f",  # go1.26.1.darwin-arm64.tar.gz
+        "d89034a0b54fdc234815fecfb76d7d06a7d180d7a6124aa47715a4cacc9fe999",  # go1.26.1.freebsd-amd64.tar.gz
+        "031f088e5d955bab8657ede27ad4e3bc5b7c1ba281f05f245bcc304f327c987a",  # go1.26.1.linux-amd64.tar.gz
+        "a290581cfe4fe28ddd737dde3095f3dbeb7f2e4065cab4eae44dfc53b760c2f7",  # go1.26.1.linux-arm64.tar.gz
     ],
     install_std = False,
-    version = "1.24.10",
+    version = "1.26.1",
 )
 
 go_stdlib(
@@ -116,7 +116,7 @@ go_repo(
 
 go_repo(
     module = "golang.org/x/net",
-    version = "v0.47.0",
+    version = "v0.52.0",
 )
 
 go_repo(

tools/build_langserver/lsp/test_data/plugins/test.build

@@ -1,5 +1,5 @@
 plugin_repo(
     name = "go",
     plugin = "go-rules",
-    revision = "v1.21.5",
+    revision = "v1.29.0",
 )