Skip to content

Add the comment inline suggestion to the transaction.search conduit endpoint #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SpangleLabs wants to merge 4 commits into
base: tm-master
Choose a base branch
from
Open

Add the comment inline suggestion to the transaction.search conduit endpoint #28

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d2fbbb7
Add the comment inline suggestion to the transaction.search conduit e…
SpangleLabs May 28, 2026
f591265
If there's no comment suggestion, set inlineSuggestion to null
SpangleLabs May 28, 2026
d1404a6
Adding a type hint
SpangleLabs May 28, 2026
f1d403b
Check the type of the comment, before assuming we can treat it as a d…
SpangleLabs May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/applications/transactions/conduit/TransactionSearchConduitAPIMethod.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,7 @@ protected function execute(ConduitAPIRequest $request) {
if ($comments) {
$removed = head($comments)->getIsDeleted();

/** @var PhabricatorApplicationTransactionComment $comment */
foreach ($comments as $comment) {
if ($removed) {
// If the most recent version of the comment has been removed,
Expand All @@ -206,10 +207,21 @@ protected function execute(ConduitAPIRequest $request) {
// removed comments.
$content = array(
'raw' => '',
'inlineSuggestion' => null,
);
} else {
$inline_suggestion = null;
// If we're looking at a comment on a differential transaction, then we can get inline suggestion data
if ($comment instanceof DifferentialTransactionComment) {
$inline_comment = $comment->newInlineCommentObject();
$comment_state = $inline_comment->getContentState();
if ($comment_state->getContentHasSuggestion()) {
$inline_suggestion = (string)$comment_state->getContentSuggestionText();
}
}
$content = array(
'raw' => (string)$comment->getContent(),
'inlineSuggestion' => $inline_suggestion,
);
}

Expand Down