Skip to content

Fix C++ runtime loading issue by correcting js-lzma dependency and paths#145

Open
Rhinoatron wants to merge 5 commits intothoth-tech:mainfrom
Rhinoatron:fix-cpp-js-lzma-path
Open

Fix C++ runtime loading issue by correcting js-lzma dependency and paths#145
Rhinoatron wants to merge 5 commits intothoth-tech:mainfrom
Rhinoatron:fix-cpp-js-lzma-path

Conversation

@Rhinoatron
Copy link
Copy Markdown

@Rhinoatron Rhinoatron commented Mar 26, 2026

This PR resolves an issue where the C++ environment remains stuck on "Loading..." due to missing js-lzma assets and incorrect file paths.

Root cause:
js-lzma dependency not present after cloning
outdated references to external/js-lzma paths

Changes:
updated all references from external/js-lzma to js-lzma
ensured required dependency is available locally
verified C++ environment initialises successfully

This fix restores full functionality of the C++ runtime environment.

@Rhinoatron
Copy link
Copy Markdown
Author

The C++ runtime issue has been resolved locally and the build now runs successfully. The remaining deploy failure appears to come from the base repository’s pull_request_target workflow, which is still attempting to download a preview artifact that is not available. Because pull_request_target uses the workflow definition from the base branch, workflow fixes made in this PR do not fully apply until this request has been merged.

Copy link
Copy Markdown

@kottochii kottochii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As most of these involve changes in the path to js-lzma and creation of the submodule, commits in most files make sense.
There has been one file that looks like product of compilation, which I assume has been placed in the PR by mistake (the only one with a comment on it) - pls delete this, if it is not required.

In terms of changes in the /workflows/, parts of them actually do make helpful changes, but they are not affecting the topic of the PR. Should it perhaps be in another pull request?

Comment thread git grep -n lzma.js
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file looks like a product of compilation. Seems like it has been accidentally added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants