update custom issue template backend tickets#1015
Open
kenslachtajr wants to merge 2 commits intomainfrom
Open
Conversation
❌ Deploy Preview for starter-dev failed.
|
Zelig880
requested changes
Feb 13, 2023
Contributor
Zelig880
left a comment
Zelig880
left a comment
There was a problem hiding this comment.
the comment here is linked to what we agree on the FE ticket
|
|
||
| Having code style consistency is important for any project. A standardized set of options should be set that can be overwritten by the implementer at a later date. | ||
|
|
||
| - ESLint: Code formatting should be enforced via ESLint rules. Rules should be set to the strictest setting and enforced via CI. The standard rules for a stack should be selected and if there are specialized plugins, those should be utilized and appropriately tuned. |
Contributor
There was a problem hiding this comment.
same comment as the FE ticket changes. i think this is too strict.
Author
There was a problem hiding this comment.
These are taken directly from the Specification. If we want to make this less strict, we should probably visit this in the Specification.
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Summary of change
Checklist