feat: add feature flag to toggle Verifiers accordion in TokenDrawer#260
feat: add feature flag to toggle Verifiers accordion in TokenDrawer#260markshenouda wants to merge 4 commits intofeat/dev-3.0-no-landingfrom
Conversation
Add SHOW_VERIFIERS_ACCORDION boolean at the top of TokenDrawer.tsx to enable/disable the verifiers expanding section and chevron. Set to false until the backend is ready; flip to true to re-enable.
There was a problem hiding this comment.
Pull request overview
Adds a local feature flag to hide/disable the Verifiers accordion UI in TokenDrawer, allowing the section to be re-enabled later when backend/data is ready.
Changes:
- Introduces
SHOW_VERIFIERS_ACCORDIONboolean to toggle the Verifiers column/accordion behavior. - Conditionally renders the Verifiers
<th>, chevron<td>, and expanded verifier row only when enabled. - Adds a safe fallback for verifiers data when the accordion is disabled.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // Get verifiers for the destination network (safe fallback to empty array) | ||
| const destinationVerifiers = SHOW_VERIFIERS_ACCORDION | ||
| ? (getVerifiersByNetwork({ | ||
| networkId: destinationChain, | ||
| environment, | ||
| version: Version.V1_2_0, | ||
| }) ?? []) | ||
| : [] |
There was a problem hiding this comment.
getVerifiersByNetwork returns Verifier entries that only contain a single address (plus id/name/type/network/logo). The Verifiers accordion content later renders both a "Source verifier address" and "Destination verifier address" column, but there isn’t enough data here to populate distinct values, so the UI will necessarily show duplicate/misleading addresses when the flag is enabled. Consider updating the accordion table to match the available data (single address) or extending the config/data shape before re-enabling.
There was a problem hiding this comment.
I think verifiers are per network, no matter destination or source, but I'll check
…or improved token drawer display
| isLoadingRateLimits, | ||
| }: NetworkLaneRowProps) { | ||
| return ( | ||
| <tr |
There was a problem hiding this comment.
You miss understood me.
What I meant was that we should split the TR that is an accordion and the one that is not. There are too many conditional in this file (over 20) for it to be just one component
Add SHOW_VERIFIERS_ACCORDION boolean at the top of TokenDrawer.tsx to enable/disable the verifiers expanding section and chevron. Set to false until the backend is ready; flip to true to re-enable.
Closing issues
closes #257