Skip to content

Conversation

@vyktoremario
Copy link

@vyktoremario vyktoremario commented Jan 23, 2026

Closes: #205

@vyktoremario vyktoremario marked this pull request as ready for review February 2, 2026 17:49
@roomote
Copy link

roomote bot commented Feb 2, 2026

Rooviewer Claude Clock   See task on Roo Cloud

All issues resolved. The pagination timing fix correctly clamps page bounds within the useMemo.

  • JourneyTabGrid.tsx: defaultValue does not update when filter changes, causing empty content when active tab is filtered out
  • JourneyCardsDesktop.tsx: Using array indices as React keys for filtered lists may cause reconciliation issues
  • JourneyCardsDesktop.tsx: Pagination reset via useEffect runs after render, causing brief flash of empty content when filtering from higher page numbers
Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@vyktoremario vyktoremario requested a review from Zelig880 February 2, 2026 17:51
@Zelig880 Zelig880 merged commit 0dbdb94 into dev-3.0 Feb 3, 2026
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants