-
Notifications
You must be signed in to change notification settings - Fork 68
update to ruby 2.6.3 #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| language: ruby | ||
| rvm: | ||
| - 2.6.3 | ||
| - 2.3.0 | ||
| - 2.2.0 | ||
| - 2.1.0 | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,64 +5,64 @@ | |
|
|
||
| SimpleCov.command_name 'minitest' | ||
|
|
||
| class TestData < MiniTest::Unit::TestCase | ||
| class TestData < Minitest::Test | ||
|
|
||
| def setup | ||
| @data = [] | ||
| CSV.foreach("test/testdata.csv") do |row| | ||
| CSV.foreach('test/testdata.csv') do |row| | ||
| @data.push row.map(&:to_f) | ||
| end | ||
| end | ||
|
|
||
| def test_sum | ||
| @data.each do |test_case| | ||
| assert_equal test_case[0,10].sum.round(6), test_case[10].round(6) | ||
| assert_equal test_case[0, 10].sum.round(6), test_case[10].round(6) | ||
| end | ||
| end | ||
|
|
||
| def test_mean | ||
| @data.each do |test_case| | ||
| assert_equal test_case[0,10].mean.round(6), test_case[11].round(6) | ||
| assert_equal test_case[0, 10].mean.round(6), test_case[11].round(6) | ||
| end | ||
| end | ||
|
|
||
| def test_median | ||
| @data.each do |test_case| | ||
| assert_equal test_case[0,10].median.round(6), test_case[12].round(6) | ||
| assert_equal test_case[0, 10].median.round(6), test_case[12].round(6) | ||
| end | ||
| end | ||
|
|
||
| def test_variance | ||
| @data.each do |test_case| | ||
| assert_equal test_case[0,10].variance.round(6), test_case[13].round(6) | ||
| assert_equal test_case[0, 10].variance.round(6), test_case[13].round(6) | ||
| end | ||
| end | ||
|
|
||
| def test_standard_deviation | ||
| @data.each do |test_case| | ||
| assert_equal test_case[0,10].standard_deviation.round(6), test_case[14].round(6) | ||
| assert_equal test_case[0, 10].standard_deviation.round(6), test_case[14].round(6) | ||
| end | ||
| end | ||
|
|
||
| def test_percentile | ||
| @data.each do |test_case| | ||
| assert_equal test_case[0,10].percentile(0).round(6), test_case[15].round(6) | ||
| assert_equal test_case[0,10].percentile(10).round(6), test_case[16].round(6) | ||
| assert_equal test_case[0,10].percentile(20).round(6), test_case[17].round(6) | ||
| assert_equal test_case[0,10].percentile(30).round(6), test_case[18].round(6) | ||
| assert_equal test_case[0,10].percentile(40).round(6), test_case[19].round(6) | ||
| assert_equal test_case[0,10].percentile(50).round(6), test_case[20].round(6) | ||
| assert_equal test_case[0,10].percentile(60).round(6), test_case[21].round(6) | ||
| assert_equal test_case[0,10].percentile(70).round(6), test_case[22].round(6) | ||
| assert_equal test_case[0,10].percentile(80).round(6), test_case[23].round(6) | ||
| assert_equal test_case[0,10].percentile(90).round(6), test_case[24].round(6) | ||
| assert_equal test_case[0,10].percentile(100).round(6), test_case[25].round(6) | ||
| assert_equal test_case[0, 10].percentile(0).round(6), test_case[15].round(6) | ||
| assert_equal test_case[0, 10].percentile(10).round(6), test_case[16].round(6) | ||
| assert_equal test_case[0, 10].percentile(20).round(6), test_case[17].round(6) | ||
| assert_equal test_case[0, 10].percentile(30).round(6), test_case[18].round(6) | ||
| assert_equal test_case[0, 10].percentile(40).round(6), test_case[19].round(6) | ||
| assert_equal test_case[0, 10].percentile(50).round(6), test_case[20].round(6) | ||
| assert_equal test_case[0, 10].percentile(60).round(6), test_case[21].round(6) | ||
| assert_equal test_case[0, 10].percentile(70).round(6), test_case[22].round(6) | ||
| assert_equal test_case[0, 10].percentile(80).round(6), test_case[23].round(6) | ||
| assert_equal test_case[0, 10].percentile(90).round(6), test_case[24].round(6) | ||
| assert_equal test_case[0, 10].percentile(100).round(6), test_case[25].round(6) | ||
| end | ||
| end | ||
|
|
||
| def test_percentile_rank | ||
| @data.each do |test_case| | ||
| assert_equal test_case[0,10].percentile_rank(50).round(6), test_case[26].round(6) | ||
| assert_equal test_case[0, 10].percentile_rank(50).round(6), test_case[26].round(6) | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would love to see rubocop implemented in this repository. Would you be open to moving any style related changes to a new pull request, one which included the rubocop package and a configuration?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sure, I will do that.
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hey, I opened the Rubocop PR as you asked, after merge we can work in the style changes 👓 |
||
| end | ||
| end | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm only seeing development changes, not changes to the code of the gem itself, and so no version bump in warranted.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, usually I do that in the patch to track any changes like updates and stuff so people can reference the new version or hold to the last they had running to avoid unwanted gem update at all. but if you prefer I can roll back the version.