Pull in latest changes to enable NodeJS 22 to work#7
Draft
karlbecker wants to merge 209 commits intomasterfrom
Draft
Pull in latest changes to enable NodeJS 22 to work#7karlbecker wants to merge 209 commits intomasterfrom
karlbecker wants to merge 209 commits intomasterfrom
Conversation
- Added Node.js version 20.10.0. - Added Node.js version 21.2.0. Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
* Update Inventory for heroku/nodejs yarn - Added Yarn version 1.22.20. - Added Yarn version 1.22.21. - Added Yarn version 3.7.0. - Added Yarn version 4.0.2. * Update CHANGELOG.md --------- Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com> Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
* Updates the metrics plugin to v14 Includes: - heroku/heroku-nodejs-plugin@v13...v14
- Added Node.js version 18.19.0. Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com> Co-authored-by: Colin Casey <casey.colin@gmail.com>
This release includes: - [heroku#1180](heroku#1180) - [heroku#1181](heroku#1181)
- Added Node.js version 21.3.0. Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
Includes a fix where the response handler in the metrics plugin can cause a crash: - heroku/heroku-nodejs-plugin#113
* This is a rewrite of the [heroku-nodejs-plugin](https://github.com/heroku/heroku-nodejs-plugin) using Node Performance APIs instead of a C++ addon to obtain equivalent details about garbage collection and event loop usage. [W-14505714](https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07EE00001eh4CDYAY/view) * Added tests for metrics * Updated CHANGELOG.md * Update metrics/metrics_collector.cjs Co-authored-by: Josh W Lewis <jlewis@heroku.com> * Feedback from PR review --------- Co-authored-by: Josh W Lewis <jlewis@heroku.com>
- Added Node.js version 21.4.0. Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
- Added Node.js version 21.5.0. Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
- Added Node.js version 20.11.0. Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
- Added Node.js version 21.6.0. Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
Co-authored-by: Colin Casey <casey.colin@gmail.com>
- Added Node.js version 21.6.1. Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
* Update concurrency calculations for larger memory footprints * Use 2048 MB WEB_MEMORY for memory heavy dynos * Drop duplicate line from WEB_CONCURRENCY * Adjust tests for memory heavy WEB_CONCURRENCY * Adjust web concurrency test value * Add changelog entry for web concurrency changes * Fix typo in changelog
Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
* Cleanup CHANGELOG.md This PR cleans up CHANGELOG.md to better match the format expected by the automation added in heroku#1200. This will allow for release links to be created which we were not doing with our manual process. * Cleanup CHANGELOG.md This PR cleans up CHANGELOG.md to better match the format expected by the automation added in heroku#1200. This will allow for release links to be created which we were not doing with our manual process. * Update CHANGELOG.md Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com> --------- Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
* Prepare release automation Adds automation to prepare a classic buildpack release. See heroku/languages-github-actions#183 * Remove "Buildpack" from workflow name * Always use Title Case for workflow display names --------- Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
- Added Yarn version 4.1.0. Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
The `CODEOWNERS` file has been adjusted to request review from the primary repository maintainer for high-traffic files that are typically updated via automation, rather than requesting review from the whole team. This is the classic Node.js buildpack equivalent of: heroku/buildpacks-nodejs#769 This: - reduces team notification/review request noise for Dependabot and release automation PRs, given that other members on the team usually aren't going to look at such PRs anyway, and it only makes it harder for team members to see the review requests that are actually in their queue - retains the "team awareness" benefit of having the team see notifications for all other non-automated PRs - retains the UX benefit of having a reviewer be automatically selected In the scenarios where either the primary repository maintainers are away, or they are the person opening the PR (so can't request review from themselves), other team members will still be able to approve the PR with the changes I've made to the branch protection settings (unchecking "Require Code Owner Review", leaving "require approvals" enabled which can only be from teams with write access, which is only us. Plus for bonus points, the option to only permit merging from members of our team has also been enabled). For supported syntax, see: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners GUS-W-14941625.
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 5.0.2 to 6.0.0. - [Release notes](https://github.com/peter-evans/create-pull-request/releases) - [Commits](peter-evans/create-pull-request@v5.0.2...v6.0.0) --- updated-dependencies: - dependency-name: peter-evans/create-pull-request dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Corrects the inventory-file related `CODEOWNERS` entry to match the actual naming of the files in this repo: - `inventory/node.toml` - `inventory/yarn.toml` (Only the CNB uses `inventory.toml`) GUS-W-14941625.
- Added Yarn version 3.8.0. Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
* Expand the Node.js metrics script usage to v14+ * Update CHANGELOG.md * Added environment variable to opt-out of the metrics script * Fix sha files that had no ending newline [W-14838650](https://gus.lightning.force.com/lightning/r/a07EE00001iPkvfYAC/view)
* Prepare release v236 * Update CHANGELOG.md --------- Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com> Co-authored-by: Colin Casey <casey.colin@gmail.com>
- Added Node.js version 18.19.1. - Added Node.js version 20.11.1. - Added Node.js version 21.6.2. Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
- Added Node.js version 18.20.8. Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
Signed-off-by: Pablo Temporini <ptemporini@salesforce.com>
- Added Yarn version 4.8.0. - Added Yarn version 4.8.1. Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
- Added Node.js version 23.11.0. Signed-off-by: Colin Casey <casey.colin@gmail.com> Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com> Co-authored-by: Colin Casey <casey.colin@gmail.com>
Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
- Added Yarn version 4.9.0. Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
- Added Yarn version 4.9.1. Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
- Added Node.js version 20.19.1. Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
- Added Node.js version 22.15.0. Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
Bumps [actions/create-github-app-token](https://github.com/actions/create-github-app-token) from 1 to 2. - [Release notes](https://github.com/actions/create-github-app-token/releases) - [Commits](actions/create-github-app-token@v1...v2) --- updated-dependencies: - dependency-name: actions/create-github-app-token dependency-version: '2' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the ruby-dependencies group with 1 update: [rspec-expectations](https://github.com/rspec/rspec-expectations). Updates `rspec-expectations` from 3.13.3 to 3.13.4 - [Release notes](https://github.com/rspec/rspec-expectations/releases) - [Changelog](https://github.com/rspec/rspec-expectations/blob/main/Changelog.md) - [Commits](https://github.com/rspec/rspec-expectations/commits) --- updated-dependencies: - dependency-name: rspec-expectations dependency-version: 3.13.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: ruby-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* As [announced here](https://devcenter.heroku.com/changelog-items/3230), the `heroku-20` stack is no longer supported for builds on Heroku. This PR drops all references for the now end-of-life stack. * Update CHANGELOG.md Signed-off-by: Colin Casey <casey.colin@gmail.com> --------- Signed-off-by: Colin Casey <casey.colin@gmail.com>
* Update Inventory for heroku/nodejs engine - Added Node.js version 24.0.0. * Add hatchet tests for Node 24 --------- Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com> Co-authored-by: Colin Casey <casey.colin@gmail.com>
Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
- Added Node.js version 24.0.1. Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
* Update release script to not contribute a default process type if any `mcp` entries are present in the `Procfile` --------- Signed-off-by: Colin Casey <casey.colin@gmail.com>
Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
- Added Node.js version 20.19.2. - Added Node.js version 22.15.1. - Added Node.js version 23.11.1. - Added Node.js version 24.0.2. Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
- Added Node.js version 22.16.0. - Added Node.js version 24.1.0. Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
Bumps the ruby-dependencies group with 2 updates: [rspec-expectations](https://github.com/rspec/rspec) and [rake](https://github.com/ruby/rake). Updates `rspec-expectations` from 3.13.4 to 3.13.5 - [Changelog](https://github.com/rspec/rspec/blob/rspec-expectations-v3.13.5/rspec-expectations/Changelog.md) - [Commits](rspec/rspec@rspec-expectations-v3.13.4...rspec-expectations-v3.13.5) Updates `rake` from 13.2.1 to 13.3.0 - [Release notes](https://github.com/ruby/rake/releases) - [Changelog](https://github.com/ruby/rake/blob/master/History.rdoc) - [Commits](ruby/rake@v13.2.1...v13.3.0) --- updated-dependencies: - dependency-name: rspec-expectations dependency-version: 3.13.5 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: ruby-dependencies - dependency-name: rake dependency-version: 13.3.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: ruby-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
mike-lang
reviewed
Jun 11, 2025
Member
mike-lang
left a comment
mike-lang
left a comment
There was a problem hiding this comment.
Think we should merge this like we did with #6 ? For now I'm using the buildpack by pointing at this branch, and it has successfully deployed my test version:
I think if it handles a staging deployment correctly it's proved itself well enough to merge. I'd want to make sure that we've seen a deployment with a real CMS environment first though as it may exercise features of the buildpack that a toy project might not. It wasn't clear to me just want app you tested this branch with.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #6 , this branch exists just to ensure we can build against Node 22. I'm probably going to use this for the next-gen BZUS I'm creating right now so to decommission the old server we have.
Think we should merge this like we did with #6 ? For now I'm using the buildpack by pointing at this branch, and it has successfully deployed my test version:
If you think it's fine, we can merge to
masteron this, too.