🛡️ Sentinel: [CRITICAL/HIGH] Fix path traversal in file download api#145
🛡️ Sentinel: [CRITICAL/HIGH] Fix path traversal in file download api#145thirdeyenation wants to merge 1 commit into
Conversation
Added a security check in `api/api_files_get.py` using `files.is_in_base_dir()` to ensure paths requested via the API are confined to the application base directory, preventing unauthorized access to the host filesystem via path traversal (e.g. `../../../etc/passwd`). Co-authored-by: thirdeyenation <133812267+thirdeyenation@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🚨 Severity: CRITICAL
💡 Vulnerability: Path Traversal (CWE-22) in
api/api_files_get.py. The API blindly accepted paths with../and absolute system paths, extracting and returning base64 encoded content of any readable file on the system.🎯 Impact: An attacker could read arbitrary sensitive files from the server, such as
/etc/passwdor environment variables, potentially leading to full system compromise.🔧 Fix: Introduced a validation check using
files.is_in_base_dir(external_path)right before file open operations. This correctly checks if the resolved absolute path still securely lives within the application's root directory, skipping the file access if it doesn't.✅ Verification: Verified by compiling the script (
python3 -m py_compile) and running isolated behavior tests.PR created automatically by Jules for task 10912107715511750359 started by @thirdeyenation