Skip to content

Conversation

@AnjaBruls
Copy link

No description provided.

@AnjaBruls AnjaBruls requested a review from joente September 20, 2021 12:28
Copy link
Member

@joente joente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a re-build is required because I added a small change to th build script. (for running on alpine linux)

Copy link
Member

@joente joente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should expose three functions: get, upsert and delete and set the corresponding cmd value as default. We then can accept the following argumets:

Get:

["get", "*"]

Upsert:

["upsert", "*"]

Delete:

["delete", "*"]

This way the example can be as follow:

gcd.get({
      entities: [
          {
              key: {
                  id: 3,
                  namespace: 'test',
                  kind: 'Test',
                  parent: {
                      kind: 'Parent',
                      id: 2,
                      namespace: 'test',
                  }
              },
          }
      ],
      kind: 'Test',
      namespace: 'test',
}).then(|res| {
    res; // just return the response.
});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants