Skip to content

Conversation

@Prjbond007
Copy link
Contributor

No description provided.

@sofci
Copy link
Collaborator

sofci commented Apr 21, 2025

Can one of the admins verify this patch?

reply test this please to run this test once

@abonislawski
Copy link
Member

WARNING: Missing commit description - Add an appropriate one

You should put full commit message just like in this example:
#9958 (comment)

@Prjbond007
Copy link
Contributor Author

I have added the description in the commit message, as done in previous PR#9958
Thanks! @abonislawski

Copy link
Member

@abonislawski abonislawski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, there is one more error in the newest version:

Copy link
Collaborator

@kv2019i kv2019i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still one extra whitespace in the one of the commits, but other than that, looks good!

@iuliana-prodan
Copy link
Contributor

@Prjbond007 for the Signed-off-by we usually put our name, so you should have something like:
Signed-off-by: Pranjal Jain<pranjalbond007@gmail.com>
not your GitHub account name.

Also, please check the codestyle/checkpatch issue on PR:
image

these should be green/pass. Click on "see details" and you'll have a description of the error/warning: https://github.com/thesofproject/sof/actions/runs/14594770306/job/40947890855?pr=9974

The goal is to have a clean and clear patch.

Thanks!

Updated the headerbar.titlebar in apply_css function to background-color for consistency.

Signed-off-by: Pranjal Jain <pranjalbond007@gmail.com>
@Prjbond007
Copy link
Contributor Author

Hi @iuliana-prodan, I’ve updated the commit message as per your suggestion, and all the checks are now passing (green).
Thanks for guiding me through the workflow! Please review and approve the changes so we can proceed with the merge.

@kv2019i kv2019i merged commit ee835eb into thesofproject:main Apr 28, 2025
41 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants