-
Notifications
You must be signed in to change notification settings - Fork 349
tools: demo-gui: fix CSS styling headerbar.titlebar #9974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can one of the admins verify this patch?
|
You should put full commit message just like in this example: |
|
I have added the description in the commit message, as done in previous PR#9958 |
abonislawski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, there is one more error in the newest version:
kv2019i
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's still one extra whitespace in the one of the commits, but other than that, looks good!
|
@Prjbond007 for the Also, please check the codestyle/checkpatch issue on PR: these should be green/pass. Click on "see details" and you'll have a description of the error/warning: https://github.com/thesofproject/sof/actions/runs/14594770306/job/40947890855?pr=9974 The goal is to have a clean and clear patch. Thanks! |
Updated the headerbar.titlebar in apply_css function to background-color for consistency. Signed-off-by: Pranjal Jain <pranjalbond007@gmail.com>
|
Hi @iuliana-prodan, I’ve updated the commit message as per your suggestion, and all the checks are now passing (green). |

No description provided.