Skip to content

[DNM] cmake/zephyr: test for src/audio/CMakeLists.txt unification part 2 #9923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kv2019i wants to merge 17 commits into from
Closed

[DNM] cmake/zephyr: test for src/audio/CMakeLists.txt unification part 2 #9923

kv2019i wants to merge 17 commits into from

Conversation

@kv2019i
Copy link
Collaborator

@kv2019i kv2019i commented Mar 24, 2025

Rebased #9912 plus revert of IIR modularization PR.

kv2019i added 17 commits March 24, 2025 20:45
@kv2019i
cmake/zephyr: unify cmake rules for src/audio/mixer/
19fd918 
Adding all source files in a single, giant zephyr/CMakeLists.txt is
inconvenient and does not scale.

Modify Zephyr rules to use definitions in src/audio/mixer instead.

Link: thesofproject#8260
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@kv2019i
cmake/zephyr: unify cmake rules for src/audio/mixin_mixout/
a43bbaa 
Adding all source files in a single, giant zephyr/CMakeLists.txt is
inconvenient and does not scale.

Modify Zephyr rules to use definitions in src/audio/mixin_mixout/
instead.

Link: thesofproject#8260
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@kv2019i
cmake/zephyr: unify cmake rules for src/audio/tone.c
fd445d9 
Adding all source files in a single, giant zephyr/CMakeLists.txt is
inconvenient and does not scale.

Modify Zephyr rules to use definitions in src/audio instead.

Link: thesofproject#8260
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@kv2019i
cmake/zephyr: unify cmake rules for src/audio/copier
8d1990f 
Adding all source files in a single, giant zephyr/CMakeLists.txt is
inconvenient and does not scale.

Modify Zephyr rules to use definitions in src/audio/copier/
instead.

Link: thesofproject#8260
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@kv2019i
cmake/zephyr: unify cmake rules for src/audio/volume/
e7727fd 
Adding all source files in a single, giant zephyr/CMakeLists.txt is
inconvenient and does not scale.

Modify Zephyr rules to use definitions in src/audio/volume/
instead.

Link: thesofproject#8260
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@kv2019i
cmake/zephyr: unify cmake rules for src/audio IPC4 modules
1bad2e1 
Adding all source files in a single, giant zephyr/CMakeLists.txt is
inconvenient and does not scale.

Modify Zephyr rules to use definitions in src/audio for base_fw
and chain_dma modules.

Link: thesofproject#8260
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@kv2019i
cmake/zephyr: unify cmake rules for src/audio/pcm_converter
f5bdfb1 
Adding all source files in a single, giant zephyr/CMakeLists.txt is
inconvenient and does not scale.

Modify Zephyr rules to use definitions in src/audio/pcm_converter/
instead.

Link: thesofproject#8260
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@kv2019i
audio: add section comments to CMakeLists.txt
fdb4e50 
Add inline comments to explain how the build rules are
organized and ordered in the file.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@kv2019i
cmake/zephyr: unify cmake rules for src/audio/aria
6cbaf2b 
Adding all source files in a single, giant zephyr/CMakeLists.txt is
inconvenient and does not scale.

Modify Zephyr rules to use definitions in src/audio/aria/
instead.

Link: thesofproject#8260
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@kv2019i
cmake/zephyr: unify cmake rules for src/audio/crossover
bdae64a 
Adding all source files in a single, giant zephyr/CMakeLists.txt is
inconvenient and does not scale.

Modify Zephyr rules to use definitions in src/audio/crossover/
instead.

Link: thesofproject#8260
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@kv2019i
cmake/zephyr: unify cmake rules for src/audio/drc
9865767 
Adding all source files in a single, giant zephyr/CMakeLists.txt is
inconvenient and does not scale.

Modify Zephyr rules to use definitions in src/audio/drc/
instead.

Link: thesofproject#8260
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@kv2019i
cmake/zephyr: unify cmake rules for src/audio/tdbf
343f336 
Adding all source files in a single, giant zephyr/CMakeLists.txt is
inconvenient and does not scale.

Modify Zephyr rules to use definitions in src/audio/tdbf/
instead.

Link: thesofproject#8260
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@kv2019i
cmake/zephyr: unify cmake rules for src/audio/up_down_mixer
86f63d0 
Adding all source files in a single, giant zephyr/CMakeLists.txt is
inconvenient and does not scale.

Modify Zephyr rules to use definitions in src/audio/up_down_mixer/
instead.

Link: thesofproject#8260
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@kv2019i
cmake/zephyr: unify cmake rules for src/audio/mux
73e01ac 
Adding all source files in a single, giant zephyr/CMakeLists.txt is
inconvenient and does not scale.

Modify Zephyr rules to use definitions in src/audio/mux/
instead.

Link: thesofproject#8260
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@kv2019i
cmake/zephyr: unify cmake rules for src/audio/multiband_drc
cb62484 
Adding all source files in a single, giant zephyr/CMakeLists.txt is
inconvenient and does not scale.

Modify Zephyr rules to use definitions in src/audio/multiband_drc/
instead.

Link: thesofproject#8260
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@kv2019i
cmake/zephyr: unify cmake rules for src/audio/mfcc
ae9e130 
Adding all source files in a single, giant zephyr/CMakeLists.txt is
inconvenient and does not scale.

Modify Zephyr rules to use definitions in src/audio/mfcc/
instead.

Link: thesofproject#8260
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
@kv2019i
Revert "math: iir: add an option to build IIR as a module"
7f5548f 
This reverts commit aaa01e4.
@kv2019i
Copy link
Collaborator Author

kv2019i commented Mar 24, 2025

@lyakh So with IIR math lib not built as module, EQ_IIR init now passes:
https://sof-ci.ostc.intel.com/#/result/planresultdetail/51398
... but it crashes in EQ_FIR init. So there seems to be some ordering dependency between LLEXT modules and my cmake PRs change the order enough to break this. Any idea is this expect, is there some rule that llext libs used by other modules need to be introduced before the modules that use them?

@kv2019i kv2019i closed this Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lyakh lyakh Awaiting requested review from lyakh lyakh will be requested when the pull request is marked ready for review lyakh is a code owner

@iuliana-prodan iuliana-prodan Awaiting requested review from iuliana-prodan iuliana-prodan will be requested when the pull request is marked ready for review iuliana-prodan is a code owner

@dbaluta dbaluta Awaiting requested review from dbaluta dbaluta will be requested when the pull request is marked ready for review dbaluta is a code owner

@abonislawski abonislawski Awaiting requested review from abonislawski abonislawski will be requested when the pull request is marked ready for review abonislawski is a code owner

@singalsu singalsu Awaiting requested review from singalsu singalsu will be requested when the pull request is marked ready for review singalsu is a code owner

@fkwasowi fkwasowi Awaiting requested review from fkwasowi fkwasowi will be requested when the pull request is marked ready for review fkwasowi is a code owner

@lgirdwood lgirdwood Awaiting requested review from lgirdwood lgirdwood will be requested when the pull request is marked ready for review lgirdwood is a code owner

@plbossart plbossart Awaiting requested review from plbossart plbossart will be requested when the pull request is marked ready for review plbossart is a code owner

@mmaka1 mmaka1 Awaiting requested review from mmaka1 mmaka1 will be requested when the pull request is marked ready for review mmaka1 is a code owner

@lbetlej lbetlej Awaiting requested review from lbetlej lbetlej will be requested when the pull request is marked ready for review lbetlej is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kv2019i