Audio: EQIIR: Tune: Small fixes and improvements #9919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sof-ctl blob format was changed to match the format needed
by ALSA UCM2 with added TVL header. The blobs for embedding to
topology are without it.
The run of "process_test('eqiir', 32, 32, 48000, 1, 1);" to run
full test for SOF IIR component failed to decoding of reference
frequency response from blob. The fail happens because the blob
decoding uses sof-ctl to generate the ABI header to help locate
the EQ blob from data.
As fix the sof_eq_blob_read() function is changed to add the
TLV header (just zeros) to tplg1 m4 format blob read.
Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This change fixes usage of sof_eq_blob_plot() when called with just blob file name. E.g. a FIR blob can be found from tools/ctl/ipc4/eq_fir/loudness.txt. There's no underscore after fir in the path to file. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This fixes the warning message: "warning: findstr is obsolete; use strfind instead". Usage of the function stfind() is similar, so there are no other changes needed. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
lgirdwood
approved these changes
Mar 24, 2025
kv2019i
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main fix is for failure of full test of process_test() for EQ components. See commit texts for descriptions.