cmake/zephyr: decentralize src/{debug/tester,math} #9901
Conversation
|
Note: using the Zephyr cmake style for all new/rewritten files, see https://github.com/orgs/thesofproject/discussions/9899 |
Adding all source files in a single, giant zephyr/CMakeLists.txt is inconvenient and does not scale. Link: thesofproject#8260 Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Adding all source files in a single, giant zephyr/CMakeLists.txt is inconvenient and does not scale. Align new cmake files with: https://docs.zephyrproject.org/latest/contribute/style/cmake.html Link: thesofproject#8260 Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Now that cmake rules are moved to same directory as source files, no need to specify the full path for source files. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reorder the add_subdirectory() statements to alphabetical order. There will be more entries here, so better to organize this list now. Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
force-pushed
the
202403-cmake-decentr-dbg-tester-and-math
branch
from
970e7ae to
29f495e
Compare
kv2019i
requested review from
LaurentiuM1234,
abonislawski,
dbaluta,
iuliana-prodan,
lbetlej,
marcinszkudlinski,
mmaka1,
pblaszko,
plbossart and
singalsu
as code owners
| if(CONFIG_CORDIC_FIXED) | ||
| add_local_sources(sof trig.c) | ||
| list(APPEND base_files trig.c) | ||
| endif() |
There was a problem hiding this comment.
can a add_list_ifdef() cmake function be used? I'm not a cmake expert, so not sure whether objects are passed by reference
There was a problem hiding this comment.
@lyakh I was going back and forth with this. Not an cmake expert here either, but given we need new owners for cmake magic in SOF, we probably need to just learn more.
We could add a function, but we'd need to add it as a SOF extension (Zephyr has list_append_if() but we can't use that).
What I'm personally not sure is that is it worth it to save some lines in definitions versus keeping SOF cmake files as close to standard cmake files as possible. I.e. functions that are used are standard cmake functions. Most of people contributing to SOF will not be cmake experts either.
On the other hand, we have a LOT of use for add_local_sources_if(), so having a replacement macro that facilitates Zephyr/XTOS might still be useful.
There was a problem hiding this comment.
Update: hmm, it seems add_local_sources_if() is already a "SOF'ism", a macro defined and used only in SOF. So it seems we've already gone the path to use SOF specific macros to avoid repetition. I can update to this approach.
kv2019i
changed the title
4 participants
cmake/zephyr: decentralize src/math/
Adding all source files in a single, giant zephyr/CMakeLists.txt is
inconvenient and does not scale.
Align new cmake files with:
https://docs.zephyrproject.org/latest/contribute/style/cmake.html
Link: #8260
Signed-off-by: Kai Vehmanen kai.vehmanen@linux.intel.com
cmake/zephyr: decentralize src/debug/tester/
Adding all source files in a single, giant zephyr/CMakeLists.txt is
inconvenient and does not scale.
Link: #8260
Signed-off-by: Kai Vehmanen kai.vehmanen@linux.intel.com
Marking as draft until #9896 is merged (part of this PR).