audio: chain_dma: don't mix link/host HDA DMA channel counts #9887
+25
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementation of get_connector_node_id() incorrectly assumes link and host DMA channel counts are always the same. Modify the implementation to look up the host and link properties separately. Link: thesofproject#9883 Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
Contributor
|
@kv2019i, the patch looks OK (I think the dt in zephyr is still wrong for cavs2.5 as you have also suspected), but CI do not like this. |
Member
|
SOFCI TEST |
ujfalusi
approved these changes
Mar 12, 2025
Collaborator
Author
|
Checkpatch warnings are in existing code (before this PR), the Intel sof-ci/jenkins fails are either notruns, So proceeding with merge. Thanks @ujfalusi for finding this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of get_connector_node_id() incorrectly assumes link and host DMA channel counts are always the same. Modify the implementation to look up the host and link properties separately.
Link: #9883