Skip to content

lib-manager: don't cast away "const" #9869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lgirdwood merged 1 commit into from
Mar 4, 2025
Merged

lib-manager: don't cast away "const" #9869

lgirdwood merged 1 commit into from
Mar 4, 2025

Conversation

@lyakh
Copy link
Collaborator

@lyakh lyakh commented Mar 3, 2025

Don't type-cast pointers to "const" objects to writable pointers even temporarily. This is error-prone and might cause future compiler warnings.

@lyakh
lib-manager: don't cast away "const"
66d6108 
Don't type-cast pointers to "const" objects to writable pointers even
temporarily. This is error-prone and might cause future compiler
warnings.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
@kv2019i kv2019i requested a review from Copilot March 3, 2025 13:16
Copilot AI reviewed Mar 3, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@lgirdwood
Copy link
Member

lgirdwood commented Mar 3, 2025

@lyakh can you check CI thanks

@lyakh
Copy link
Collaborator Author

lyakh commented Mar 4, 2025 •
edited
Loading

@lyakh can you check CI thanks

@lgirdwood I dare say, that this is a pure compile-time change, since both variables to which expressions are assigned, are const too. So really surprised to see the "Internal Intel CI" failing. @wszypelt has anything broken the down-mix test?

@lgirdwood lgirdwood merged commit 0d777cb into thesofproject:main Mar 4, 2025
47 of 49 checks passed
@lyakh lyakh deleted the const branch March 4, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@lgirdwood lgirdwood lgirdwood approved these changes

@kv2019i kv2019i kv2019i approved these changes

@tmleman tmleman tmleman approved these changes

@plbossart plbossart Awaiting requested review from plbossart plbossart is a code owner

@mmaka1 mmaka1 Awaiting requested review from mmaka1 mmaka1 is a code owner

@lbetlej lbetlej Awaiting requested review from lbetlej lbetlej is a code owner

@dbaluta dbaluta Awaiting requested review from dbaluta dbaluta is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lyakh @lgirdwood @kv2019i @tmleman