modules: toml: Use values from uuid-registry in toml files #9861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing uuids entries for brngup and cold modules in the uuid-registry.txt file. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
Instruct the toml file preprocessor to also use the definitions from the uuid-registry.h file. This will allow the values placed in the uuid-registry to be used in toml files. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
Separate the sof_llext_write_uuids function into a new file, llext_write_uuids.cmake. Add support for lowercase uuids. Fix invalid escape before -. Retrieve the identifiers from a preprocessed rimage_config.toml file, where the uuids names have been replaced with the actual identifiers. To enable this, run the script after building the module. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
In all preprocessed toml files, replace uuid values with their corresponding identifiers from the uuid-registry. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
Change the identifier defined in the code to the one retrieved from the uuid-registry. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
Change the identifiers defined in the code to the one retrieved from the uuid-registry. Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
softwarecki
requested review from
abonislawski,
jxstelter,
kv2019i,
lgirdwood,
lyakh,
marcinszkudlinski,
serhiy-katsyuba-intel and
tmleman
softwarecki
requested review from
a team,
RanderWang,
dbaluta,
fkwasowi,
iuliana-prodan,
lbetlej,
mmaka1,
pblaszko,
plbossart,
singalsu and
tlissows
as code owners
marcinszkudlinski
approved these changes
Feb 26, 2025
Contributor
marcinszkudlinski
left a comment
marcinszkudlinski
left a comment
There was a problem hiding this comment.
Removing repetitions of magic UUIDs is always welcome
tmleman
approved these changes
Feb 27, 2025
serhiy-katsyuba-intel
approved these changes
Feb 27, 2025
Member
|
DUT configuration failure using old 6.9 kernel https://sof-ci.01.org/sofpr/PR9861/build11133/devicetest/index.html?model=PTLH_HDA_AIOC&testcase=check-sof-logger and unrelated to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing uuids entries for brngup and cold modules in the uuid-registry.txt file.
Instruct the toml file preprocessor to also use the definitions from the
uuid-registry.hfile. This will allow the values placed in the uuid-registry to be used in toml files.Separate the
sof_llext_write_uuidsfunction into a new file,llext_write_uuids.cmake. Add support for lowercase uuids. Fix invalidescape before -. Retrieve the identifiers from a preprocessed
rimage_config.tomlfile, where the uuids names have been replaced with the actual identifiers. To enable this, run the created script after building the module.In all preprocessed toml files, replace uuid values with their corresponding identifiers from the uuid-registry.
Change the identifier defined in the code to the one retrieved from the uuid-registry.