Tools: rimage / topology2: ASRC component related fixes #9849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
WIP - I'm still working with issue with kernel support for this. This should address issue #9845 . |
singalsu
force-pushed
the
asrc_add_rimage
branch
from
b937225 to
39073cf
Compare
singalsu
requested review from
dbaluta,
jsarha,
kv2019i,
lbetlej,
mmaka1,
plbossart and
ranj063
as code owners
Collaborator
Author
|
This looks now complete, with linux patch thesofproject/linux#5335 things work for me. |
singalsu
commented
Feb 21, 2025
tools/rimage/config/tgl-h.toml
Outdated
| affinity_mask = "0x3" | ||
| instance_count = "2" | ||
| domain_types = "0" | ||
| load_type = LOAD_TYPE |
Collaborator
Author
There was a problem hiding this comment.
This needs fix, should be "0"
This change includes ASRC component into firmware for TGL and TGL-H platforms. The .toml entry for ASRC is copied from asrc.toml data for MTL. This is enough to be able to run and test ASRC in TGL platforms. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This patch fixes the configuration tokens for ASRC with IPC4, the tokens asynchronous_mode and rate_in from IPC3 are not valid. In IPC4 all the control is packed to bit-fiels in operation mode. Token rate_out is in use as before. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
force-pushed
the
asrc_add_rimage
branch
from
39073cf to
441a0fe
Compare
lgirdwood
approved these changes
Feb 24, 2025
Collaborator
@lgirdwood this PR touches TGL, which doesn't use LLEXT, and topology2, which I cannot verify by just looking at the PR. So I'm afraid I don't have any specific input to this PR. If it works with ASRC in monolithic MTL+ configurations, it should work with LLEXT too. |
ujfalusi
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.